Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.flask: 1.0.3 -> 1.1.0 #64332

Closed
wants to merge 1 commit into from
Closed

pythonPackages.flask: 1.0.3 -> 1.1.0 #64332

wants to merge 1 commit into from

Conversation

migmruiz
Copy link

@migmruiz migmruiz commented Jul 5, 2019

Motivation for this change

Bumping to the latest version, with security fixes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@migmruiz migmruiz requested a review from FRidh as a code owner July 5, 2019 10:02
@FRidh FRidh self-assigned this Jul 17, 2019
mtrsk
mtrsk reviewed Aug 24, 2019
View reviewed changes
pkgs/development/python-modules/flask/default.nix
@@ -2,12 +2,12 @@
, itsdangerous, click, werkzeug, jinja2, pytest }:

buildPythonPackage rec {
version = "1.0.3";
version = "1.1.0";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 1.1.1 was released 3 days after your sent this PR. Might be a chance to upgrade this before it gets merged.

@arcnmx arcnmx mentioned this pull request Sep 2, 2019
Merged
10 tasks
@migmruiz
Copy link
Author

This is not the most up-to-date anylonger and we had a minor version bump merged that's conflicting now. Since this is very old and unlikely to get merged anyway I'm closing it

@migmruiz migmruiz closed this Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrsk mtrsk mtrsk left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@FRidh FRidh

Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@migmruiz @mtrsk @FRidh @Janik-Haag