Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging]bash-completion: 2.8 -> 2.9 #66599

Merged
merged 1 commit into from Oct 22, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 14, 2019

Motivation for this change

update packages @r-ryantm cannot.

Changelog located: https://github.com/scop/bash-completion/blob/master/CHANGES

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @peti

not really sure how to test this

$ nix path-info -Sh ./result
/nix/store/r7zq02r87ixkv6lb0ip2014ydn6ii2dz-bash-completion-2.9  965.6K
$ nix path-info -Sh ./result
/nix/store/lrvfslpvawf7q54bgwbi1msskklmg7p6-bash-completion-2.8  913.1K

@FRidh
Copy link
Member

FRidh commented Sep 1, 2019

This needs to be rebased.

@FRidh
Copy link
Member

FRidh commented Oct 22, 2019

Please rebase

@jonringer
Copy link
Contributor Author

done

@FRidh FRidh merged commit 12fd773 into NixOS:staging Oct 22, 2019
@jonringer jonringer deleted the bump-bash-completion-staging branch October 22, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants