Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trusted Types] Deprecate expose param in createPolicy, add defaultPolicy. #18400

Merged
merged 1 commit into from Aug 19, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Aug 13, 2019

Remove getExposedPolicy and replace it with a defaultPolicy property, which is needed internally and fixes #992031 in one go.

Bug: 992006, 992031
Change-Id: Ic5f1ae6a9001a18cb72828fd8b854453605d3c84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751723
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Commit-Queue: Stefano Sanfilippo <ssanfilippo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688056}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1751723 branch 3 times, most recently from 64e14fa to 2ed67af Compare August 13, 2019 15:42
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title Deprecate expose parameter in TrustedTypePolicyFactory.createPolicy. Deprecate expose parameter in TrustedTypePolicyFactory.createPolicy, add defaultPolicy. Aug 14, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title Deprecate expose parameter in TrustedTypePolicyFactory.createPolicy, add defaultPolicy. Deprecate expose in TrustedTypePolicyFactory.createPolicy, add .defaultPolicy. Aug 14, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1751723 branch 3 times, most recently from 119452a to 79ea429 Compare August 14, 2019 11:08
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title Deprecate expose in TrustedTypePolicyFactory.createPolicy, add .defaultPolicy. [TT] Deprecate expose parameter in createPolicy, add defaultPolicy. Aug 14, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title [TT] Deprecate expose parameter in createPolicy, add defaultPolicy. [TT] Deprecate expose param in createPolicy, add defaultPolicy attribute. Aug 14, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1751723 branch 2 times, most recently from ba3e2be to d485776 Compare August 14, 2019 12:26
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title [TT] Deprecate expose param in createPolicy, add defaultPolicy attribute. [Trusted Types] Deprecate expose param in createPolicy, add defaultPolicy. Aug 14, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1751723 branch 4 times, most recently from d02ce68 to 737d62f Compare August 15, 2019 12:28
…licy.

Remove getExposedPolicy and replace it with a defaultPolicy property, which is needed internally and fixes #992031 in one go.

Bug: 992006, 992031
Change-Id: Ic5f1ae6a9001a18cb72828fd8b854453605d3c84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751723
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Commit-Queue: Stefano Sanfilippo <ssanfilippo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688056}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants