Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warzone: 3.2.3 -> 3.3.0 #66500

Merged
merged 2 commits into from Sep 10, 2019
Merged

warzone: 3.2.3 -> 3.3.0 #66500

merged 2 commits into from Sep 10, 2019

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Aug 12, 2019 •
edited

Motivation for this change

The latest stable is a bit old. Is it ok to update to a beta?
EDIT: the new stable came out yesterday, did an update.

Also this PR wraps the application for #65399.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (is wrapped and runs with nix-shell --pure -p --run)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @astsmtl

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Aug 12, 2019

@GrahamcOfBorg build warzone2100

@rnhmjoj rnhmjoj changed the title warzone: 3.2.3 -> 3.3.0_beta1 warzone: 3.2.3 -> 3.3.0 Sep 2, 2019
@ofborg ofborg bot requested a review from astsmtl September 2, 2019 12:02
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Sep 7, 2019

The url has changed again, hopefully the last time.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Sep 7, 2019

@GrahamcOfBorg build warzone2100

@Mic92 Mic92 merged commit 3203053 into NixOS:master Sep 10, 2019
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Sep 11, 2019

@Mic92 Can you cherry pick this in 19.09 or should I open another PR? I think it's currently broken for missing some Qt library.

@Mic92
Copy link
Member

Mic92 commented Sep 11, 2019 •
edited

done:

[detached HEAD 76ef329] warzone: 3.2.3 -> 3.3.0_beta1
Author: rnhmjoj rnhmjoj@inventati.org
Date: Mon Aug 12 02:38:33 2019 +0200
1 file changed, 20 insertions(+), 10 deletions(-)
Press Enter to continue
[detached HEAD 75ba6bb] warzone: 3.3.0_beta1 -> 3.3.0
Author: rnhmjoj rnhmjoj@inventati.org
Date: Mon Sep 2 13:42:47 2019 +0200
1 file changed, 4 insertions(+), 5 deletions(-)

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Sep 11, 2019

Thank you!

@rnhmjoj rnhmjoj deleted the warzone branch September 14, 2019 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@astsmtl astsmtl Awaiting requested review from astsmtl

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rnhmjoj @Mic92