Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s3ql: 2.26 -> 3.2 #66557

Merged
merged 1 commit into from Aug 15, 2019
Merged

s3ql: 2.26 -> 3.2 #66557

merged 1 commit into from Aug 15, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Aug 13, 2019 •
edited

Motivation for this change

Updating the package and fixing the build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @rushmorem

@mmahut mmahut requested a review from rushmorem August 13, 2019 10:00
aanderse
aanderse approved these changes Aug 15, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran nix-review and everything checked out. Visiting the existing homepage noted that the project now exists on github, as described by this PR.

LGTM 👍

@aanderse aanderse merged commit 8bf23fb into NixOS:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

@rushmorem rushmorem Awaiting requested review from rushmorem

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmahut @aanderse