Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync changes from mozilla-central #3735

Merged
merged 11 commits into from Aug 15, 2019
Merged

Sync changes from mozilla-central #3735

merged 11 commits into from Aug 15, 2019

Conversation

moz-gfx
Copy link

@moz-gfx moz-gfx commented Aug 13, 2019 •
edited by larsbergstrom

This change is Reviewable

brennie and others added 3 commits August 13, 2019 10:02
@brennie
Bug 1570442 - Flip upside down recorded frames right side up on non-A…
1232762 
…NGLE configurations r=kvark

Frames captured by the composition recorder on non-ANGLE configurations were
previously written upside down to disk. We now flip them right side up when
mapping them into memory.

Differential Revision: https://phabricator.services.mozilla.com/D40113

[wrupdater] From https://hg.mozilla.org/mozilla-central/rev/dccb73a9ee2b1ae7e890eac4d18769bfa8f2857b
@Eijebong
Bug 1573039 - Part 1: Update image to 0.22. r=emilio
27a4698 
Differential Revision: https://phabricator.services.mozilla.com/D41488

[wrupdater] From https://hg.mozilla.org/mozilla-central/rev/d07875a4f37441f92045e491b07b0f7fe0f6de97
@gw3583
Bug 1572646 - Detect and optimize picture cache tiles that are solid …
ff05e03 
…colors. r=kvark

With this patch, tiles that are covered only by the opaque backdrop
primitive are detected and noted as solid colors.

Solid color tiles save memory and performance, because:
 - No texture slice is allocated as a render target for them.
 - No need to rasterize this tile.
 - Drawing the tile is done with the faster rectangle shader.

This already saves performance and GPU memory on quite a few
real world sites (esp. when running at 4k). However, the main
benefit of this will be once we enable picture caching on
multiple content slices and the UI layer. When this occurs, it's
important to avoid allocating tile buffers for all the solid
rectangle tiles that the UI layer typically contains.

Differential Revision: https://phabricator.services.mozilla.com/D41342

[wrupdater] From https://hg.mozilla.org/mozilla-central/rev/96075609026a3816cb7a6dcf9cf3795afe7f82d6
@moz-gfx
Copy link
Author

moz-gfx commented Aug 13, 2019

@bors-servo r+

@cbrewster
Bug 1178765 - Part 1: Add backdrop-filter WebRender display items r=gw
c02d77f 
Differential Revision: https://phabricator.services.mozilla.com/D39097

[wrupdater] From https://hg.mozilla.org/mozilla-central/rev/b5d6ed62cda18c51ae303d6b904771850a3d1e03
@cbrewster
Bug 1178765 - Part 2: Implement backdrop-filter in WebRender r=gw
e16844b 
Differential Revision: https://phabricator.services.mozilla.com/D39098

[wrupdater] From https://hg.mozilla.org/mozilla-central/rev/abdb4f5f3323cc1474d02a3722741c5d2cea5df7
@cbrewster
Bug 1178765 - Part 5: Add optimization to render task depth assignmen…
ba96f6e 
…t r=gw,nical

Fixes an issue when backdrop-filter is used many time on a page where we would
spend a large amount of time reevaluating render tasks when assigning task depths.

Differential Revision: https://phabricator.services.mozilla.com/D41252

[wrupdater] From https://hg.mozilla.org/mozilla-central/rev/0c820a515e16953b3945ac670dac13099a568f6a
@moz-gfx
Copy link
Author

moz-gfx commented Aug 14, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit ff05e03 has been approved by moz-gfx

cbrewster and others added 3 commits August 15, 2019 09:53
@moz-gfx
Copy link
Author

moz-gfx commented Aug 15, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit ba96f6e has been approved by moz-gfx

@emilio
Copy link
Member

emilio commented Aug 15, 2019

@bors-servo r-

  • Bors ist tot.

@emilio
Copy link
Member

emilio commented Aug 15, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 60d37bd has been approved by emilio

@bors-servo
Copy link
Contributor

⌛ Testing commit 60d37bd with merge d9bc207...

bors-servo pushed a commit that referenced this pull request Aug 15, 2019
Auto merge of #3735 - moz-gfx:wrupdater, r=emilio
d9bc207 
Sync changes from mozilla-central

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3735)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - status-appveyor

@SimonSapin
Copy link
Member

On macOS:

    Checking image v0.22.1
     Running `rustc --crate-name image /Users/worker/.cargo/registry/src/github.com-1ecc6299db9ec823/image-0.22.1/./src/lib.rs --color never --crate-type lib --emit=dep-info,metadata -C panic=abort -C debuginfo=2 --cfg 'feature="bmp"' --cfg 'feature="default"' --cfg 'feature="dxt"' --cfg 'feature="gif"' --cfg 'feature="gif_codec"' --cfg 'feature="hdr"' --cfg 'feature="ico"' --cfg 'feature="jpeg"' --cfg 'feature="jpeg-decoder"' --cfg 'feature="jpeg_rayon"' --cfg 'feature="png"' --cfg 'feature="png_codec"' --cfg 'feature="pnm"' --cfg 'feature="scoped_threadpool"' --cfg 'feature="tga"' --cfg 'feature="tiff"' --cfg 'feature="webp"' -C metadata=d3e3c10f50641fb2 -C extra-filename=-d3e3c10f50641fb2 --out-dir /Users/worker/generic-worker/generic-worker-taskdir/task_1565864548/webrender/target/debug/deps -L dependency=/Users/worker/generic-worker/generic-worker-taskdir/task_1565864548/webrender/target/debug/deps --extern byteorder=/Users/worker/generic-worker/generic-worker-taskdir/task_1565864548/webrender/target/debug/deps/libbyteorder-0bc3734dffb00430.rmeta --extern gif=/Users/worker/generic-worker/generic-worker-taskdir/task_1565864548/webrender/target/debug/deps/libgif-525e72a487bf66ba.rmeta --extern jpeg_decoder=/Users/worker/generic-worker/generic-worker-taskdir/task_1565864548/webrender/target/debug/deps/libjpeg_decoder-ea3da78a04148120.rmeta --extern lzw=/Users/worker/generic-worker/generic-worker-taskdir/task_1565864548/webrender/target/debug/deps/liblzw-869ea2693557ef47.rmeta --extern num_iter=/Users/worker/generic-worker/generic-worker-taskdir/task_1565864548/webrender/target/debug/deps/libnum_iter-1f6ae22905e05213.rmeta --extern num_rational=/Users/worker/generic-worker/generic-worker-taskdir/task_1565864548/webrender/target/debug/deps/libnum_rational-5c4c33a29bcf128e.rmeta --extern num_traits=/Users/worker/generic-worker/generic-worker-taskdir/task_1565864548/webrender/target/debug/deps/libnum_traits-a8678d6107b27403.rmeta --extern png=/Users/worker/generic-worker/generic-worker-taskdir/task_1565864548/webrender/target/debug/deps/libpng-d8fa1d6733f834c1.rmeta --extern scoped_threadpool=/Users/worker/generic-worker/generic-worker-taskdir/task_1565864548/webrender/target/debug/deps/libscoped_threadpool-0a922434184f6469.rmeta --extern tiff=/Users/worker/generic-worker/generic-worker-taskdir/task_1565864548/webrender/target/debug/deps/libtiff-f9266a7f17f862a8.rmeta --cap-lints allow --deny warnings`
rustc(69948,0x7000094cd000) malloc: *** error for object 0xda1943b0: pointer being freed was not allocated
*** set a breakpoint in malloc_error_break to debug
error: Could not compile `image`.

On Windows:

Reftests with unexpected results:
	reftests\text\split-batch.yaml == reftests\text\split-batch-ref.yaml

WARN: rx::HLSLCompiler::compileToBinary(228): 
C:\fakepath(1766,14-129): warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally handle negative values if you expect them
C:\fakepath(1772,58-112): warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally handle negative values if you expect them
C:\fakepath(1789,67-72): warning X3556: integer divides may be much slower, try using uints if possible.
C:\fakepath(1792,46-51): warning X3556: integer modulus may be much slower, try using uints if possible.
C:\fakepath(1812,29-78): warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally handle negative values if you expect them
C:\fakepath(1642,1-6): warning X4000: use of potentially uninitialized variable (dyn_index_vec4_float4)
C:\fakepath(1927,25-29): error X4576: Input array signature parameter SV_Position cannot be indexed dynamically.
WARN: rx::HLSLCompiler::compileToBinary(228): 
C:\fakepath(1766,14-129): warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally handle negative values if you expect them
C:\fakepath(1772,58-112): warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally handle negative values if you expect them
C:\fakepath(1789,67-72): warning X3556: integer divides may be much slower, try using uints if possible.
C:\fakepath(1792,46-51): warning X3556: integer modulus may be much slower, try using uints if possible.
C:\fakepath(1812,29-78): warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally handle negative values if you expect them
C:\fakepath(1642,1-6): warning X4000: use of potentially uninitialized variable (dyn_index_vec4_float4)
C:\fakepath(1927,25-29): error X4576: Input array signature parameter SV_Position cannot be indexed dynamically.
WARN: rx::HLSLCompiler::compileToBinary(228): 
C:\fakepath(1789,67-72): warning X3556: integer divides may be much slower, try using uints if possible.
C:\fakepath(1792,46-51): warning X3556: integer modulus may be much slower, try using uints if possible.
C:\fakepath(1642,1-6): warning X4000: use of potentially uninitialized variable (dyn_index_vec4_float4)
C:\fakepath(1693,1): warning X4000: use of potentially uninitialized variable (f_distance_aa)
C:\fakepath(1730,1): warning X4000: use of potentially uninitialized variable (f_do_clip)
WARN: rx::HLSLCompiler::compileToBinary(228): 
C:\fakepath(1968,58-112): warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally handle negative values if you expect them
C:\fakepath(1962,14-129): warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally handle negative values if you expect them
C:\fakepath(1991,79-84): warning X3556: integer divides may be much slower, try using uints if possible.
C:\fakepath(1994,46-51): warning X3556: integer modulus may be much slower, try using uints if possible.
C:\fakepath(2010,29-78): warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally handle negative values if you expect them
C:\fakepath(1667,1-6): warning X4000: use of potentially uninitialized variable (dyn_index_vec4_float4)

@staktrace
Copy link
Contributor

The Windows failure is intermittent, it showed up a few times before. Dunno about the macOS one.

@staktrace
Copy link
Contributor

I guess updating rustc on the macOS worker is probably a good idea and might fix the issue.

@moz-gfx
Copy link
Author

moz-gfx commented Aug 15, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors-servo
Copy link
Contributor

📌 Commit 50e7b47 has been approved by moz-gfx

@bors-servo
Copy link
Contributor

⌛ Testing commit 50e7b47 with merge cdfafba...

bors-servo pushed a commit that referenced this pull request Aug 15, 2019
Auto merge of #3735 - moz-gfx:wrupdater, r=moz-gfx
cdfafba 
Sync changes from mozilla-central

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3735)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: moz-gfx
Pushing cdfafba to master...

@bors-servo bors-servo merged commit 50e7b47 into servo:master Aug 15, 2019
@bors-servo bors-servo mentioned this pull request Aug 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@moz-gfx @bors-servo @emilio @SimonSapin @staktrace @brennie @Eijebong @gw3583 @cbrewster @aiakab