Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sysdig: 0.26.1 -> 0.26.2 #66523

Merged
merged 1 commit into from Aug 12, 2019
Merged

sysdig: 0.26.1 -> 0.26.2 #66523

merged 1 commit into from Aug 12, 2019

Conversation

charles-dyfis-net
Copy link
Contributor

Motivation for this change

Fixes a crash in the kernel module in kernels that use SIG_SEND_NOINFO with SIGKILL, as introduced in torvalds/linux@98af37d, which has been backported to kernel trees as old as 4.19.x.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @7c6f434c

@mmahut
Copy link
Member

mmahut commented Aug 12, 2019

@GrahamcOfBorg build sysdig

@ofborg ofborg bot requested a review from 7c6f434c August 12, 2019 11:58
@7c6f434c 7c6f434c merged commit 0ff831d into NixOS:master Aug 12, 2019
@charles-dyfis-net charles-dyfis-net deleted the sysdig-0.26.2 branch August 12, 2019 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@charles-dyfis-net @mmahut @7c6f434c