Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tinyprog: init at 1.0.24.dev99+ga77f828 #66521

Merged
merged 2 commits into from Aug 15, 2019
Merged

tinyprog: init at 1.0.24.dev99+ga77f828 #66521

merged 2 commits into from Aug 15, 2019

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Aug 12, 2019

Motivation for this change

This is the programmer used for USB TinyFPGA devices. A previous pull request to add it, #52878, stalled out. I've used the git version because there's no source tarball on PyPI and there have been a substantial number of changes since the last release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @thoughtpolice as potentially interested going by the yosys/icestorm maintainers? :)

Sorry for the minor deluge of new packages!

@emilazy emilazy requested a review from FRidh as a code owner August 12, 2019 11:19
@mmahut
Copy link
Member

mmahut commented Aug 13, 2019

@GrahamcOfBorg build tinyprog jsonmerge

@thoughtpolice
Copy link
Member

LGTM, thank you @emilazy!

@thoughtpolice thoughtpolice merged commit 6aa1b0a into NixOS:master Aug 15, 2019
@emilazy emilazy deleted the add-tinyprog branch August 18, 2019 02:29
@rembo10 rembo10 mentioned this pull request Dec 19, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emilazy @mmahut @thoughtpolice