Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "gitlab-runner: don't bundle prebuilt docker images" #66522

Merged
merged 1 commit into from Aug 12, 2019
Merged

Revert "gitlab-runner: don't bundle prebuilt docker images" #66522

merged 1 commit into from Aug 12, 2019

Conversation

bachp
Copy link
Member

@bachp bachp commented Aug 12, 2019

Reverts #66225

As we don't have the git hash in our runner, the runner can't fetch the images until https://gitlab.com/gitlab-org/gitlab-runner/issues/4509 is fixed.

@zimbatm I think it's best to revert this. Sorry for the trouble.

max-wittig
max-wittig approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@max-wittig max-wittig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. LGTM

@zimbatm zimbatm merged commit f5d84bb into NixOS:master Aug 12, 2019
@bachp bachp deleted the revert-66225-gitlab-runner-unbundle branch August 12, 2019 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-wittig max-wittig max-wittig approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bachp @max-wittig @zimbatm