Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keepassxc: 2.4.1 -> 2.4.3 #66572

Merged
merged 1 commit into from Aug 22, 2019
Merged

keepassxc: 2.4.1 -> 2.4.3 #66572

merged 1 commit into from Aug 22, 2019

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Aug 13, 2019 •
edited

Motivation for this change

Patch update. Probably needs backport to stable, I see data loss and security fixes in the changelog.
edit: stable is still on 2.3 though

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jonafato

The darwin patch didn't apply anymore due to minor changes and offsets, so I manually applied and regenerated it. It may need testing on darwin.

@mmahut
Copy link
Member

mmahut commented Aug 13, 2019

@GrahamcOfBorg build keepassxc

@jonafato
Copy link
Contributor

Does this fix the Darwin build failures that exist on #63939? My PR has been open for a while, but I don't have a macOS machine to debug this on.

@Mic92
Copy link
Member

Mic92 commented Aug 14, 2019

cc @knedlsepp for macOS support.

@knedlsepp
Copy link
Member

ofborg builds it just fine: https://github.com/NixOS/nixpkgs/pull/66572/checks?check_run_id=192706749 Might not be able to check if it actually runs in the next few days however.

@jonafato jonafato mentioned this pull request Aug 15, 2019
Closed
10 tasks
@jonafato
Copy link
Contributor

Unless someone can reproduce the build failures from my linked pull request, I'd like to get this merged so the fixes are available in nixpkgs.

@mmahut mmahut merged commit 9fd5b75 into NixOS:master Aug 22, 2019
@gloaming gloaming mentioned this pull request Aug 25, 2019
Closed
@fgaz fgaz deleted the keepassxc/update1 branch May 11, 2021 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonafato jonafato jonafato approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fgaz @mmahut @jonafato @Mic92 @knedlsepp