Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]beakerbrowser:init at 0.8.8 #66571

Closed
wants to merge 1 commit into from
Closed

[WIP]beakerbrowser:init at 0.8.8 #66571

wants to merge 1 commit into from

Conversation

pasqui23
Copy link
Contributor

Motivation for this change

Solves #38037

Things done

Not yet wrking

nix build -f . 'nodePackages."beakerbrowser-git+https://github.com/beakerbrowser/beaker.git"'                                  
error: 'buildNodePackage' at /home/paki/src/nixpkgs/pkgs/development/node-packages/node-env.nix:377:5 called without required argument 'version', at /home/paki/src/nixpkgs/lib/customisation.nix:69:12
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@pasqui23 pasqui23 changed the title beakerbrowser:init at 0.8.8 [WIP]beakerbrowser:init at 0.8.8 Aug 13, 2019
@wamserma
Copy link
Member

@pasqui23 Are you still working on this?

@pasqui23
Copy link
Contributor Author

No,if I redid this it would be on a different branch to recapture the new versions

@pasqui23 pasqui23 closed this May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pasqui23 @wamserma