Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mirrors: Add centos mirror #66537

Merged
merged 1 commit into from Aug 20, 2019
Merged

mirrors: Add centos mirror #66537

merged 1 commit into from Aug 20, 2019

Conversation

knedlsepp
Copy link
Member

Motivation for this change

This should remove the need to rename links from mirror.centos.org to vault.centos.org as the removed comment mentions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member

veprbl commented Aug 13, 2019

I think this is a misuse of the mirrors feature because you don't actually provide any mirrors. The same effect can be achieved if you just put those urls in list into the urls parameter to the fetchurl.

@knedlsepp
Copy link
Member Author

knedlsepp commented Aug 13, 2019

I think this is a misuse of the mirrors feature because you don't actually provide any mirrors. The same effect can be achieved if you just put those urls in list into the urls parameter to the fetchurl.

Oh. Will try this instead! Not sure though if this will also work for: urlPrefix

@knedlsepp
Copy link
Member Author

@veprbl While using urls does work, I cannot get urlPrefixes to work. As far as I understood this should point to the prefix which was used for the successful download of the packagesList. Any help here would be greatly appreciated.

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be okay. They do separate by centos version on http://mirror.centos.org, but not on any of the mirrors listed on their website https://www.centos.org/download/mirrors/ .

We could also drop couple mirrors in the list like
http://ftp.ussg.iu.edu/linux/centos/
http://centos.uib.no/

@knedlsepp
Copy link
Member Author

knedlsepp commented Aug 13, 2019

Most of the mirrors suffer from the same problem: Deprecated versions will just be replaced with directories containing the readme pointing to vault.centos.org: http://ftp.ussg.iu.edu/linux/centos/7.3.1611/

I did find some mirrors for centos-vault, will add these.

This should remove the need to rename links from mirror.centos.org to
vault.centos.org as the removed comment mentions.
@knedlsepp
Copy link
Member Author

knedlsepp commented Aug 13, 2019

Figured while we previously used both centos-6/ and centos-7/, there is actually also a plain mirror.centos.org/centos, which holds both of them.
I think this is now a pretty clean solution, e.g. compare:

@veprbl
Copy link
Member

veprbl commented Aug 13, 2019

Most of the mirrors suffer from the same problem: Deprecated versions will just be replaced with directories containing the readme pointing to vault.centos.org:
http://ftp.ussg.iu.edu/linux/centos/7.3.1611/

Yes, I think this is a very standard strategy: most mirrors provide only current versions which are also most popular. Fewer mirrors will have enough resources to also mirror all of the releases.

Nice catch with centos-{6,7}/ to centos/, indeed.

@mmahut
Copy link
Member

mmahut commented Aug 20, 2019

What's next here?

@veprbl veprbl merged commit bacf561 into NixOS:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants