Tested with neovim on NixOS only. Reviewer: Please test with Vim as well as Darwin!

nix-build -I nixpkgs=. -E 'with import <nixpkgs> {}; neovim.override { configure = { vam.pluginDictionaries = [ "vim-terraform" ]; }; }' --show-trace

Not sure this is a good idea. The issue linked by @gloaming mentions that they

• are not sure if filetype on can be completely undone
• each filetype on adds ~100ms overhead

Not sure this is a good idea. The issue linked by @gloaming mentions that they

* are not sure if `filetype on` can be completely undone

* each `filetype on` adds ~100ms overhead

We already had it in the vimRC. I merely moved it to the top.

EDIT: I see what you mean, sorry for missing your point. Another way to solve this is to enable this patch only for the manifest generation. It might still break the result vim. I'll give it a shot.

EDIT: I see what you mean, sorry for missing your point. Another way to solve this is to enable this patch only for the manifest generation. It might still break the result vim. I'll give it a shot.

@timokau It seems to work for me if I enabled at the top only for generating the manifest. What do you think of this approach?

I don't think you missed my point; On the contrary, I missed that we already set filetype on. Not sure why we do that, not really our place to change the defaults. But since we already do...

But then there's still justinmk's point in neovim/neovim#6596 (comment) that this may interfere with plugin managers. So your new solution is probably better. Not sure why plugin managers do the filetype off/filetype on dance in the first place though.

Instead of earlyFiletype, maybe we want a more general beforePlugins escape hatch? Then we could just say beforePlugins = "filetype ident on". Paying the 100ms twice only for the manifest generation shouldn't matter.

@timokau sure that sounds like a good idea. I've added beforePlugins and afterPlugins as it makes sense to have both. Obviously, the manifest generation only needs the beforePlugins.

PTAL

Isn't afterPlugins == customRC? I wonder what other plugin managers do. If they also don't set filetype on, how is it plugins like vim-terraform don't fail for them?

PTAL

I don't know that acronym.

Isn't afterPlugins == customRC?

That's right. I removed it then.

I wonder what other plugin managers do. If they also don't set filetype on, how is it plugins like vim-terraform don't fail for them?

I'm not sure actually, that's a good question. We could take this discussion on a separate issue and look deeper into plugins. Maybe @junegunn could chime in here as well.

PTAL

I don't know that acronym.

Please Take Another Look :)

I wonder what other plugin managers do. If they also don't set filetype on, how is it plugins like vim-terraform don't fail for them?

I'm not sure actually, that's a good question. We could take this discussion on a separate issue and look deeper into plugins. Maybe junegunn could chime in here as well.

Right, I'm fine with merging this for now if it fixes the immediate build failure 👍. Anything else can be done as a followup.

Please Take Another Look :)

Good to go :)