kernel generate-config.pl: Allow whitespace in values #66538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, this allows setting CONFIG_CMDLINE to a value with multiple space-seperated parameters. Other variables also take free-form strings and might similarly benefit.
teto
reviewed
Aug 13, 2019
| @@ -28,7 +28,7 @@ | |||
| while (<ANSWERS>) { | |||
| chomp; | |||
| s/#.*//; | |||
| if (/^\s*([A-Za-z0-9_]+)(\?)?\s+(\S+)\s*$/) { | |||
| if (/^\s*([A-Za-z0-9_]+)(\?)?\s+(.*\S)\s*$/) { | |||
There was a problem hiding this comment.
Without the terminating \S, the .* will match trailing whitespace. The original pattern ignored leading and trailing whitespace and I didn't want to change that behavior.
|
would be cool to have a test for it. Maybe also change the branch to merge to to staging as this PR triggers many rebuilds. |
|
A test for that might be a bit overkill. |
|
Since most of the packages built here are kernel modules, I will merge this right away to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
In particular, this allows setting CONFIG_CMDLINE to a value with
multiple space-seperated parameters. Other variables also take free-form
strings and might similarly benefit.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @dezgeg