Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dockerTools: document extraCommands, increase layers #66543

Merged
merged 3 commits into from Aug 15, 2019
Merged

dockerTools: document extraCommands, increase layers #66543

merged 3 commits into from Aug 15, 2019

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Aug 13, 2019 •
edited

Motivation for this change

Document extraCommands for buildLayeredImage, and raise the layer count since it is a much higher limit in reality.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@grahamc
Copy link
Member Author

grahamc commented Aug 13, 2019

cc @vaibhavsagar because he wasn't surprised it wasn't documented.

jonringer
jonringer approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I know it's a common theme in nixpkgs that extraCommands is a (or part of a) script. However, for Docker, it's not readily apparent you're talking about that or actual "docker commands" like "EXPOSE 443" (Yes, that goes elsewhere, but the terms are similar)

doc/functions/dockertools.xml Outdated Show resolved Hide resolved
@grahamc @jonringer
doc/functions/dockertools.xml: clarify that "Commands" means shell co…
abf82a1 
…mmands

Co-Authored-By: Jon <jonringer@users.noreply.github.com>
@grahamc grahamc merged commit ee30e62 into NixOS:master Aug 15, 2019
@grahamc grahamc deleted the dt branch August 15, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grahamc @jonringer