-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revolve shouldn't be possible for 3D groups #458
Comments
Lathe isn't very useful for solids either. What would you like to happen? |
Probably pop up the same kind of window that I get when trying to make a new workspace group without selecting an origin, etc. (or just grey out that option?) |
The check for that would go in Group::MenuGroup() under the cases for those group types. Question on Localization, is it OK if we use the exact same string for the error message in multiple places in the code? If so, should we? The test would be similar to the one used in Extrude groups and should be in Revolve and Helix groups too. It occurs to me that in weird cases, doing this with Lathe might create circles that are relevant to someone somewhere. |
Completely identical messages get grouped into a single group by gettext so that's fine.
Fortunately, existing files with such strange constructs will continue to work correctly. And if someone complains and it turns out we missed an important use case, we can always revert. |
System information
SolveSpace version: 3.0~97c8cb7d
Operating system: Debian buster
Expected behavior
I tried to use the new "Revolve" feature, initially trying to sweep a solid. It appears that is not supported (only sweeping a 2D sketch), so it shouldn't have let me do it.
Actual behavior
It let me do it, but the result didn't make any sense.
The text was updated successfully, but these errors were encountered: