Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revolve shouldn't be possible for 3D groups #458

Closed
rpavlik opened this issue Aug 14, 2019 · 5 comments
Closed

Revolve shouldn't be possible for 3D groups #458

rpavlik opened this issue Aug 14, 2019 · 5 comments

Comments

@rpavlik
Copy link
Contributor

rpavlik commented Aug 14, 2019

System information

SolveSpace version: 3.0~97c8cb7d

Operating system: Debian buster

Expected behavior

I tried to use the new "Revolve" feature, initially trying to sweep a solid. It appears that is not supported (only sweeping a 2D sketch), so it shouldn't have let me do it.

Actual behavior

It let me do it, but the result didn't make any sense.

@phkahler
Copy link
Member

phkahler commented Aug 14, 2019

Lathe isn't very useful for solids either. What would you like to happen?

@rpavlik
Copy link
Contributor Author

rpavlik commented Aug 19, 2019

Probably pop up the same kind of window that I get when trying to make a new workspace group without selecting an origin, etc. (or just grey out that option?)

@phkahler
Copy link
Member

The check for that would go in Group::MenuGroup() under the cases for those group types. Question on Localization, is it OK if we use the exact same string for the error message in multiple places in the code? If so, should we?

The test would be similar to the one used in Extrude groups and should be in Revolve and Helix groups too. It occurs to me that in weird cases, doing this with Lathe might create circles that are relevant to someone somewhere.

@whitequark
Copy link
Contributor

Question on Localization, is it OK if we use the exact same string for the error message in multiple places in the code? If so, should we?

Completely identical messages get grouped into a single group by gettext so that's fine.

It occurs to me that in weird cases, doing this with Lathe might create circles that are relevant to someone somewhere.

Fortunately, existing files with such strange constructs will continue to work correctly. And if someone complains and it turns out we missed an important use case, we can always revert.

@phkahler
Copy link
Member

Implemented Fix in commit 2dd50d0 of PR #466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants