Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1573725] turn on the pref for text-decoration-thickness on by default (in early-beta and earlier) #18427

Merged
merged 1 commit into from Aug 15, 2019

Conversation

moz-wptsync-bot
Copy link
Collaborator

Differential Revision: https://phabricator.services.mozilla.com/D41883

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1573725
gecko-commit: 27209bcee14fe4bdbfb87c1f128035b3d1cb7f96
gecko-integration-branch: autoland
gecko-reviewers: dholbert

…y-beta and earlier)

Differential Revision: https://phabricator.services.mozilla.com/D41883

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1573725
gecko-commit: 27209bcee14fe4bdbfb87c1f128035b3d1cb7f96
gecko-integration-branch: autoland
gecko-reviewers: dholbert
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@dholbert
Copy link
Contributor

dholbert commented Aug 14, 2019

Note: this commit removes some "invalid" values that are no longer invalid, now that text-decoration-thickness exists and is a subproperty of text-decoration.

We probably should've atomically moved these values from the -invalid.html test to the -valid.html test, but I didn't think of it until after code-review and after the patch landed. I filed followup https://bugzilla.mozilla.org/show_bug.cgi?id=1573974 to update the -valid.html testcase, and presumably that will spawn another WPT pull request once it's fixed.

@moz-wptsync-bot moz-wptsync-bot merged commit 6a8fe55 into master Aug 15, 2019
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1573725 branch August 15, 2019 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants