Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1571764] Subtract combobox display frame border-padding when inferring the height from line-height. #18426

Merged
merged 2 commits into from Aug 15, 2019

Conversation

moz-wptsync-bot
Copy link
Collaborator

This fixes it and seems to be an acceptable fix... Should I make it conditional
on box-sizing: border-box for completeness? The display frame has border-box
box-sizing, and not having it would be a bug, I'd think...

Differential Revision: https://phabricator.services.mozilla.com/D41939

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1571764
gecko-commit: bd44d2dd0c02c1e2ab10e73695ee3ef1da971aa6
gecko-integration-branch: autoland
gecko-reviewers: mats, jfkthame

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

…ght from line-height.

This fixes it and seems to be an acceptable fix... Should I make it conditional
on box-sizing: border-box for completeness?  The display frame has border-box
box-sizing, and not having it would be a bug, I'd think...

Differential Revision: https://phabricator.services.mozilla.com/D41939

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1571764
gecko-commit: ad04c84153da637000c7a472ccbc248116b5c330
gecko-integration-branch: autoland
gecko-reviewers: mats, jfkthame
…have border-radius.

MANUAL PUSH: Orange

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1571764
gecko-commit: bd8ef39cfadc0e427b1261ae8b2b2f7677d85bd2
gecko-integration-branch: autoland
@moz-wptsync-bot moz-wptsync-bot merged commit 95fc0af into master Aug 15, 2019
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1571764 branch August 15, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants