Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lv: init at 4.51 #66629

Merged
merged 2 commits into from
Oct 12, 2019
Merged

lv: init at 4.51 #66629

merged 2 commits into from
Oct 12, 2019
+41 −0

Conversation

kayhide
Copy link
Contributor

@kayhide kayhide commented Aug 14, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Aug 14, 2019
@mmahut
Copy link
Member

mmahut commented Aug 15, 2019

@GrahamcOfBorg build lv

@mmahut
Copy link
Member

mmahut commented Aug 18, 2019

@GrahamcOfBorg build lv

@kayhide
add kayhide to maintainers list.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
b172c44
@kayhide kayhide mentioned this pull request Sep 1, 2019
Closed
10 tasks
@mmahut
Copy link
Member

mmahut commented Sep 2, 2019

@GrahamcOfBorg build lv

@aanderse
Copy link
Member

@GrahamcOfBorg build lv
@mmahut did you test this by chance?
@kayhide I apologize for the delay.

aanderse
aanderse approved these changes Oct 12, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and good to go 👍
Thanks for your contribution and sorry for the delay @kayhide. Stay safe.

@aanderse aanderse merged commit 7c1de1f into NixOS:master Oct 12, 2019
@kayhide
Copy link
Contributor Author

kayhide commented Oct 13, 2019

@aanderse Great, thanks!
No worry about the delay, I understand you got a huge amount of issues and PRs.
Thanks for your great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut

@aanderse aanderse

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kayhide @mmahut @aanderse