Handle null effect when interrupting a transition #18428
Conversation
If the effect of a CSS Transition is removed (via the getAnimations API) and then the transition is interrupted by removing the 'to' style, we previously assumed that the effect would always exist. This CL adds a null-check for that case. Bug: 992668 Change-Id: I399be7fd859bac0ca6e7ee1e29dbcbbae2e89403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753671 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#686932}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1753671
branch
from
9cb1116
to
bbe3726
Compare
| // reversal logic to apply. | ||
| await singleFrame(); | ||
| assert_not_equals(transition.currentTime, 0); | ||
| assert_not_equals(getComputedStyle(div).left, '0px'); |
There was a problem hiding this comment.
@stephenmcgruer This test is failing on Firefox because it produces '0px' here. I don't think there's anything in the spec requiring that it have moved past 0px by this point (e.g. due to pixel rounding).
Based on the comment above this block I don't believe this assertion is needed (only the first one is). Would you mind dropping it?
If it is needed, would you mind reworking the test to wait until the value of left is actually non-zero?
Thanks.
There was a problem hiding this comment.
Argh, sorry, you're totally right. That's what I get for being lazy and not testing on Firefox, sorry.
I'll fix this tomorrow when I get to work. It's a bit weird because its really a regression test for Chromium, but we're meant to land all tests as WPT these days so I try to at least make them applicable to all browsers (e.g. test some real behavior). The test should wait until left is non-zero.
If the effect of a CSS Transition is removed (via the getAnimations API)
and then the transition is interrupted by removing the 'to' style, we
previously assumed that the effect would always exist. This CL adds a
null-check for that case.
Bug: 992668
Change-Id: I399be7fd859bac0ca6e7ee1e29dbcbbae2e89403
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753671
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686932}