New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce magicleap servo screen resolution #23963
Conversation
In an attempt to get something to land tonight, I'm going to okay this PR, which will land all three magicleap PRs. They've all been r+d by Manish. @bors-servo r=Manishearth |
📌 Commit b4565dd has been approved by |
Reduce magicleap servo screen resolution <!-- Please describe your changes on the following line: --> Reduce the magicleap resolution from 720p to 480p. (Videos at 720p seem to lag.) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because we don't test native UI <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23963) <!-- Reviewable:end -->
💔 Test failed - status-taskcluster |
@bors-servo retry |
💣 Failed to start rebuilding: |
Reduce magicleap servo screen resolution <!-- Please describe your changes on the following line: --> Reduce the magicleap resolution from 720p to 480p. (Videos at 720p seem to lag.) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because we don't test native UI <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23963) <!-- Reviewable:end -->
☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster |
Reduce the magicleap resolution from 720p to 480p. (Videos at 720p seem to lag.)
./mach build -d
does not report any errors./mach test-tidy
does not report any errorsThis change is