Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update toml to 0.5 and cbindgen to 0.9 #23958

Merged
merged 2 commits into from Aug 16, 2019
Merged

Update toml to 0.5 and cbindgen to 0.9 #23958

merged 2 commits into from Aug 16, 2019

Conversation

Eijebong
Copy link
Contributor

@Eijebong Eijebong commented Aug 13, 2019 •
edited by SimonSapin

This change is Reviewable

@Eijebong
Force the std feature for log
62e46cf 
While trying to build this crate with the gecko feature rust complained
about us using `log::set_boxed_logger` because it requires the std feature
which was not explicitly set in that crate.
@Eijebong
Update toml to 0.5 and cbindgen to 0.9
f7411db
@highfive
Copy link

Heads up! This PR modifies the following files:

  • @emilio: components/style/Cargo.toml

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 13, 2019
@highfive
Copy link

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@nox
Copy link
Contributor

nox commented Aug 13, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit f7411db has been approved by nox

@highfive highfive assigned nox and unassigned asajeffrey Aug 13, 2019
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 13, 2019
@bors-servo
Copy link
Contributor

⌛ Testing commit f7411db with merge bb70858...

bors-servo pushed a commit that referenced this pull request Aug 13, 2019
Auto merge of #23958 - Eijebong:toml, r=nox
bb70858 
Update toml to 0.5 and cbindgen to 0.9

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23958)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 13, 2019
@Eijebong
Copy link
Contributor Author 

{
    "status": "FAIL", 
    "group": "default", 
    "message": "/css/css-text/overflow-wrap/overflow-wrap-anywhere-004.html cce352a593b41b44ff29f4b09088e5097c264fc2\n/css/css-text/overflow-wrap/reference/overflow-wrap-break-word-001-ref.html a24c9e46c2dbc06aa73635ec71e73ffd84dc95eb", 
    "stack": null, 
    "subtest": null, 
    "test": "/css/css-text/overflow-wrap/overflow-wrap-anywhere-004.html", 
    "line": 16915, 
    "action": "test_result", 
    "expected": "PASS"
}
{
    "status": "FAIL", 
    "group": "default", 
    "message": "/css/css-text/overflow-wrap/overflow-wrap-break-word-001.html cce352a593b41b44ff29f4b09088e5097c264fc2\n/css/css-text/overflow-wrap/reference/overflow-wrap-break-word-001-ref.html a24c9e46c2dbc06aa73635ec71e73ffd84dc95eb", 
    "stack": null, 
    "subtest": null, 
    "test": "/css/css-text/overflow-wrap/overflow-wrap-break-word-001.html", 
    "line": 16941, 
    "action": "test_result", 
    "expected": "PASS"
}

I don't see how my PR would do that so I guess intermittent ?

@jdm
Copy link
Member

jdm commented Aug 15, 2019

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit f7411db with merge 54d8640...

bors-servo pushed a commit that referenced this pull request Aug 16, 2019
Auto merge of #23958 - Eijebong:toml, r=nox
54d8640 
Update toml to 0.5 and cbindgen to 0.9

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23958)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Aug 16, 2019
@bors-servo
Copy link
Contributor

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: nox
Pushing 54d8640 to master...

@bors-servo bors-servo merged commit f7411db into servo:master Aug 16, 2019
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Eijebong @highfive @nox @bors-servo @jdm @asajeffrey