Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stm32loader: init at 0.5.0 #66497

Merged
merged 2 commits into from Aug 12, 2019
Merged

stm32loader: init at 0.5.0 #66497

merged 2 commits into from Aug 12, 2019

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Aug 11, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg eval

@emilazy
Copy link
Member Author

emilazy commented Aug 12, 2019

(Updated to put it in pythonPackages as well, as I realized it can be used as a Python library.)

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you enable tests?

After examining you should be able to do this with

checkInputs = [ pytest ];

checkPhase = ''
  pytest --strict tests/unit
'';

checkInputs docs

I also noticed that you didn't add a maintainers meta attribute.
Did you plan on maintaining this?

@worldofpeace
Copy link
Contributor

Noticed the repo on GitHub was missing a tag for the latest release.
Opened an issue: florisla/stm32loader#27.

@worldofpeace
Copy link
Contributor

(Updated to put it in pythonPackages as well, as I realized it can be used as a Python library.)

Is there documentation for this use?

@emilazy emilazy force-pushed the add-stm32loader branch 2 times, most recently from 3dfbbd2 to 256dfe6 Compare August 12, 2019 01:31
@emilazy
Copy link
Member Author

emilazy commented Aug 12, 2019

Thanks for the feedback; I wasn't sure whether it was appropriate to add myself to the maintainers list unilaterally. I'm happy to try and keep it updated as I use it, though I don't have a particularly great SLA against entropy and bitrot.

Is there documentation for this use?

Not as far as I can tell, but florisla/stm32loader#10 shows the intent. Thorough documentation unfortunately seems to be a bit of a rare luxury in embedded development...

@worldofpeace
Copy link
Contributor

Thanks for the feedback; I wasn't sure whether it was appropriate to add myself to the maintainers list unilaterally. I'm happy to try and keep it updated as I use it, though I don't have a particularly great SLA against entropy and bitrot.

Yep, and I can say you've performed everything properly.

Not as far as I can tell, but florisla/stm32loader#10 shows the intent. Thorough documentation unfortunately seems to be a bit of a rare luxury in embedded development...

Thanks, that allows me to be sure. And yes it's pretty rare in embedded development 😄

@worldofpeace
Copy link
Contributor

worldofpeace commented Aug 12, 2019

I've built everything locally, let's see how it goes on the builder

@GrahamcOfBorg build python37.pkgs.stm32loader python36.pkgs.stm32loader python35.pkgs.stm32loader python27.pkgs.stm32loader stm32loader

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks passed, is packaged appropriately 👍

@worldofpeace worldofpeace merged commit ee877d7 into NixOS:master Aug 12, 2019
@emilazy emilazy deleted the add-stm32loader branch August 12, 2019 05:55
@worldofpeace
Copy link
Contributor

Yay, upstream is going to continue tagging their releases and maintaining a changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants