New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stm32loader: init at 0.5.0 #66497
stm32loader: init at 0.5.0 #66497
Conversation
@GrahamcOfBorg eval |
74ec95d
to
4375cd9
Compare
(Updated to put it in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you enable tests?
After examining you should be able to do this with
checkInputs = [ pytest ];
checkPhase = ''
pytest --strict tests/unit
'';
checkInputs
docs
I also noticed that you didn't add a maintainers
meta attribute.
Did you plan on maintaining this?
Noticed the repo on GitHub was missing a tag for the latest release. |
Is there documentation for this use? |
3dfbbd2
to
256dfe6
Compare
Thanks for the feedback; I wasn't sure whether it was appropriate to add myself to the maintainers list unilaterally. I'm happy to try and keep it updated as I use it, though I don't have a particularly great SLA against entropy and bitrot.
Not as far as I can tell, but florisla/stm32loader#10 shows the intent. Thorough documentation unfortunately seems to be a bit of a rare luxury in embedded development... |
Yep, and I can say you've performed everything properly.
Thanks, that allows me to be sure. And yes it's pretty rare in embedded development 😄 |
256dfe6
to
42e55db
Compare
I've built everything locally, let's see how it goes on the builder @GrahamcOfBorg build python37.pkgs.stm32loader python36.pkgs.stm32loader python35.pkgs.stm32loader python27.pkgs.stm32loader stm32loader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All checks passed, is packaged appropriately 👍
Yay, upstream is going to continue tagging their releases and maintaining a changelog |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)