New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diagonal tunnels and bridges. #7696
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finnish: 2 changes by hpiirai english (us): 17 changes by Supercheese luxembourgish: 10 changes by Phreeze dutch: 20 changes by JanWillem norwegian (bokmal): 2 changes by Leifbk latin: 16 changes by Supercheese portuguese: 3 changes by JayCity
Display of industry production around tiles (as shown when placing a station) did not take account of the station catchment changes, so still showed production from an industry even if it was not covered by a tile. This is fixed by making a set of nearby industries that are covered, instead of looping over all possible industries.
Const and non-const Find() have different return types.
luxembourgish: 29 changes by Phreeze russian: 2 changes by Lone_Wolf latin: 4 changes by Supercheese portuguese: 1 change by JayCity
…ound, so use it. (#7427) Previously the distance was thrown away, only to be expensively recalculated again.
korean: 14 changes by telk5093
italian: 25 changes by lorenzodv portuguese: 3 changes by JayCity
…or legibility against darker blue of sea introduced by #7436
…er references. (#7431) Linkgraph nodes require a specific order that was maintained by swapping just the last element for the node to be removed. std::vector::erase() changed this to removing the node is then shuffling the remain items down, which upsets other references to this indices. This is fixed by switching back to the original swap & pop method.
…terating tiles. (#7429)
) In the autoreplace window, the rail type drop down is for choosing engines of the given time. Many rail types do not have engines specifically designed for them, and are merely compatible with other rail types. This list is thus unwieldy and many options have no engines available. As this drop down is for choosing _engine_ rail type rather than compatible rail types, we can list just the rail types explicitly listed by engines.
It is skipped when NPF is in use. It is trivial to work around by adding and removing dummy orders. It is mostly alleviated by the ship path cache in YAPF.
english (us): 3 changes by Supercheese spanish (mexican): 18 changes by Absay hungarian: 2 changes by Brumi latin: 33 changes by Supercheese
dutch: 2 changes by JanWillem french: 19 changes by glx
The AllRules ruleset causes the VS 2019 editor to litter warning squiggles all over the place, about things that would never be fixed. Limit it to the smallest ruleset available. Warnings shown now mainly concern potential arithmetic overflows.
welsh: 4 changes by kazzie
welsh: 13 changes by kazzie spanish: 35 changes by lpenap
swedish: 49 changes by daishan spanish: 80 changes by lpenap
CompanyID is 8 bit wide, so this incorrect cast would make it impossible to create story page elements for pages past 255.
Null pointer dereference occurred when either origin_tile or dest_tile were waypoint tiles.
…moved. Code based on the patch by JGRennison. JGRennison/OpenTTD-patches@ac84f34
Add `getsysdate` console command to display system's local time, which is might be useful to check current time in script logging.
english (us): 2 changes by njn
danish: 2 changes by njn
…ror message as it should be.
Not by opening a pull request that attempts to merge 1.9 into master, that's for sure It's been discussed many times in the past, there's a lot of issues with getting it to actually look good, drawing new graphics, and making sure the engine actually supports it |
Charles,
Thanks for the quick response.
Well, dreaming is allowed. lol
gb
“O êxito na vida não se mede pelo que você conquistou, mas sim pelas
dificuldades que superou no caminho.” *Abraham Lincoln*
Em qua, 14 de ago de 2019 às 06:59, Charles Pigott <notifications@github.com>
escreveu:
… Not by opening a pull request that attempts to merge 1.9 into master,
that's for sure
It's been discussed many times in the past, there's a lot of issues with
getting it to actually look good, drawing new graphics, and making sure the
engine actually supports it
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7696?email_source=notifications&email_token=ALUZFR7XSX3FYT5MJ3EUYY3QEPJOTA5CNFSM4ILTDRK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4IJ7BQ#issuecomment-521183110>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALUZFR3W7JJNP6M4H7U4B53QEPJOTANCNFSM4ILTDRKQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it possible to implement tunnels and diagonal bridges, as are the rails?