Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error when using the 'webgl_backtrace' feature #23966

Merged
merged 1 commit into from Aug 16, 2019

Conversation

mmatyas
Copy link
Contributor

@mmatyas mmatyas commented Aug 14, 2019

This patch fixes a build error that happens when building with --features webgl_backtrace.

However, while working on this I've noticed that calling Backtrace::new() instantly causes a segmentation fault. This didn't happen with the example code of the package though, so I wasn't sure where to report this (maybe related: backtrace-rs/#150, backtrace-rs/#189).

cc @alexcrichton @jdm


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___
  • These changes fix an issue that happens with a compile time feature not tested by the CI

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webglrenderingcontext.rs
  • @KiChjang: components/script/dom/webglrenderingcontext.rs

@highfive
Copy link

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 14, 2019
@ferjm
Copy link
Contributor

ferjm commented Aug 14, 2019

r? @jdm

@highfive highfive assigned jdm and unassigned ferjm Aug 14, 2019
@jdm
Copy link
Member

jdm commented Aug 15, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 72b273a has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 15, 2019
@bors-servo
Copy link
Contributor

⌛ Testing commit 72b273a with merge ff3f3d3...

bors-servo pushed a commit that referenced this pull request Aug 16, 2019
Fix build error when using the 'webgl_backtrace' feature

This patch fixes a build error that happens when building with `--features webgl_backtrace`.

However, while working on this I've noticed that calling `Backtrace::new()` instantly causes a segmentation fault. This didn't happen with the example code of [the package](https://crates.io/crates/backtrace) though, so I wasn't sure where to report this (maybe related: [backtrace-rs/#150](rust-lang/backtrace-rs#150), [backtrace-rs/#189](rust-lang/backtrace-rs#189)).

cc @alexcrichton @jdm

---

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___
- [x] These changes fix an issue that happens with a compile time feature not tested by the CI

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23966)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing ff3f3d3 to master...

@bors-servo bors-servo merged commit 72b273a into servo:master Aug 16, 2019
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants