Use observer for sync bases #18419
Merged
Use observer for sync bases #18419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 14, 2019
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1753004
branch
3 times, most recently
from
c3d2a62
to
90efa06
Compare
Previously sync bases would not be updated if the base element was swapped out. This has been changed to allow for this. Making events and sync bases work more uniformly. This is the first step in changing sync base repeats into actual sync bases. Bug: 993702 Change-Id: I1a1b381d094100296a420de8877bb1e57cd9709e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753004 Commit-Queue: Edvard Thörnros <edvardt@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by: Fredrik Söderquist <fs@opera.com> Auto-Submit: Edvard Thörnros <edvardt@opera.com> Cr-Commit-Position: refs/heads/master@{#686838}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1753004
branch
from
90efa06
to
89a6b5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously sync bases would not be updated if the base element was
swapped out. This has been changed to allow for this. Making events
and sync bases work more uniformly.
This is the first step in changing sync base repeats into actual
sync bases.
Bug: 993702
Change-Id: I1a1b381d094100296a420de8877bb1e57cd9709e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753004
Commit-Queue: Edvard Thörnros <edvardt@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Auto-Submit: Edvard Thörnros <edvardt@opera.com>
Cr-Commit-Position: refs/heads/master@{#686838}