Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msgpack: 3.0.1 -> 3.2.0 #66615

Merged
merged 1 commit into from Mar 14, 2020
Merged

msgpack: 3.0.1 -> 3.2.0 #66615

merged 1 commit into from Mar 14, 2020

Conversation

rychale
Copy link
Contributor

@rychale rychale commented Aug 14, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@mmahut
Copy link
Member

mmahut commented Aug 15, 2019

@GrahamcOfBorg build msgpack

@risicle
Copy link
Contributor

risicle commented Aug 15, 2019

nix-review checks out for me apart from the already failing pymol. Non-nixos linux x86_64.

@risicle
Copy link
Contributor

risicle commented Aug 16, 2019

nix-review also checks out for me on macos 10.13 apart from already failing packages.

@rixed
Copy link
Contributor

rixed commented Nov 17, 2019

Also build on nixos, with this warning though:

warning: there are multiple derivations named 'msgpack-3.2.0'; using the first one

Note also that there is no meta section and therefore no maintainer.
Maybe it's time to fix this?

@alyssais alyssais merged commit 7ed8a2c into NixOS:master Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants