maintainers: compare maintainer usernames in lowercase #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least a few maintainers in <nixpkgs>/maintainers/maintainer-list.nix specified a lowercase username for GitHub while actually having a username with upper case characters. Ofborg performs case-sensitive comparisons on PR submitters and the above mentioned usernames. This causes borg to not recognize users when there is different casing between the above list and the 'user.name' value of github's api response, even though the casing is irrelevant for distinguishing different users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least a few maintainers in
<nixpkgs>/maintainers/maintainer-list.nixspecified a lowercase username for GitHub while actually having a
username with upper case characters.
Ofborg performs case-sensitive comparisons on PR submitters and the
above mentioned usernames. This causes borg to not recognize users when
there is different casing between the above list and the 'user.name'
value of github's api response, even though the casing is irrelevant for
distinguishing different users.
Please note that I don't know how to really test if this works as expected and would appreciate input on how to do that or how to improve my change :)
I did however build ofborg.{php,rs} and executed the
checkPhasefrom shell.nix.