Implement CSS comparison functions min/max #18409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 13, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1744799
branch
from
63c3157
to
f5f38ba
Compare
This patch implements the CSSComparison functions min/max following spec: https://drafts.csswg.org/css-values-4/#comp-func 1. New CSSMathOperator types and a new CSSMathExpressionNode subclass are added, so that CSSMathFunctionValue can represent an expression that involves min() and max() 2. Parser support for min() and max() are added 3. Conversions between CSSMathFunctionValue and CalculationValue are augmented to support comparisons A minimal test suite is also added to verify reachability of the newly added code. The following will be finished by future patches: - Bridging comparison functions with CSS typed OM objects - Supporting comparison functions in the 'sizes' attribute - Adding a comprehensive wpt test suite for comparison functions Bug: 825895 Change-Id: I5bbf09b62818f733573f6d38837c68e555fcae59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744799 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#687414}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1744799
branch
from
f5f38ba
to
31a271d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements the CSSComparison functions min/max following
spec: https://drafts.csswg.org/css-values-4/#comp-func
New CSSMathOperator types and a new CSSMathExpressionNode subclass
are added, so that CSSMathFunctionValue can represent an expression
that involves min() and max()
Parser support for min() and max() are added
Conversions between CSSMathFunctionValue and CalculationValue are
augmented to support comparisons
A minimal test suite is also added to verify reachability of the newly
added code.
The following will be finished by future patches:
Bug: 825895
Change-Id: I5bbf09b62818f733573f6d38837c68e555fcae59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744799
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687414}