Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magicleap 16x9 #23955

Merged
merged 2 commits into from Aug 14, 2019
Merged

Magicleap 16x9 #23955

merged 2 commits into from Aug 14, 2019

Conversation

asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Aug 12, 2019

Get the magicleap demo app 16x9 rather than square.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because we don't test native ui

This change is Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 12, 2019
@asajeffrey
Copy link
Member Author

The first commit is #23953. r? @Manishearth

@Manishearth
Copy link
Member

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit db4edae has been approved by Manishearth

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 12, 2019
@bors-servo
Copy link
Contributor

⌛ Testing commit db4edae with merge acaad42...

bors-servo pushed a commit that referenced this pull request Aug 13, 2019
Magicleap 16x9

<!-- Please describe your changes on the following line: -->

Get the magicleap demo app 16x9 rather than square.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because we don't test native ui

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23955)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 13, 2019
@bors-servo bors-servo merged commit db4edae into servo:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-magic leap S-tests-failed The changes caused existing tests to fail.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants