Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code health refactoring of animation.cc. #18399

Merged
merged 1 commit into from Aug 21, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Aug 13, 2019

This patch aligns the implementation of web-animations with the spec.
Previously updates were performed via a PlayStateUpdateScope. This
class depended on an extra state (kPending) that is not to spec.
Support for microtasks is also introduced in this patch, which
addresses most of the remaining timing issues with the finished state
of an animation.

Bug: 960944
Change-Id: I62aff2254d2b5265f869415e0f763e140b460c37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739386
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689018}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

This patch aligns the implementation of web-animations with the spec.
Previously updates were performed via a PlayStateUpdateScope. This
class depended on an extra state (kPending) that is not to spec.
Support for microtasks is also introduced in this patch, which
addresses most of the remaining timing issues with the finished state
of an animation.

Bug: 960944
Change-Id: I62aff2254d2b5265f869415e0f763e140b460c37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739386
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689018}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants