Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

looking-glass-client: a12 -> B1 #66513

Merged
merged 2 commits into from Aug 18, 2019
Merged

Conversation

alexbakker
Copy link
Member

Motivation for this change

There was a new upstream release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @pneumaticat

@mmahut
Copy link
Member

mmahut commented Aug 12, 2019

@GrahamcOfBorg build looking-glass-client

@kliu128
Copy link

kliu128 commented Aug 12, 2019

@alexbakker I no longer use VFIO & this package, but the diff looks fine to me. May want to remove me from the maintainers list, since I can no longer test it.

@alexbakker
Copy link
Member Author

@Pneumaticat I can do that, but can a package have 0 maintainers? I don't feel comfortable maintaining a package myself (yet) as I started using NixOS only recently.

@kliu128
Copy link

kliu128 commented Aug 12, 2019

@alexbakker Looks like there is at least one other currently unmaintained package.

However, I'd encourage you to add yourself as a maintainer if you are willing - there are no formal requirements - you just get alerted when the package fails to build or potentially mentioned if someone else makes a change.

@alexbakker
Copy link
Member Author

@Pneumaticat Alright. I've replaced your username with mine.

@kliu128
Copy link

kliu128 commented Aug 14, 2019

@alexbakker Thanks - @mmahut are you able to review? [I don't have merge permissions, so I can't merge the update.]

@mmahut
Copy link
Member

mmahut commented Aug 15, 2019

@GrahamcOfBorg build looking-glass-client

@mmahut mmahut self-assigned this Aug 15, 2019
@mmahut mmahut merged commit 17f72af into NixOS:master Aug 18, 2019
@alexbakker alexbakker deleted the looking-glass-client-b1 branch August 23, 2019 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants