Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML report (--log-html) shows incorrect summary #18408

Open
galmacky opened this issue Aug 13, 2019 · 6 comments
Open

HTML report (--log-html) shows incorrect summary #18408

galmacky opened this issue Aug 13, 2019 · 6 comments
Labels
infra priority:backlog wptrunner The automated test runner, commonly called through ./wpt run

Comments

@galmacky
Copy link
Contributor

Commandline tried:
./wpt run android_webview dom/ --log-html a.html --log-mach -
(chrome_android shows a similar result)

a.html (attached) has the following summary:
322 tests ran in 534.9 seconds.
0 passed, 0 skipped, 0 failed, 10 errors.
0 expected failures, 0 unexpected passes, 0 known intermittent results.

This doesn't seem quite right because the number of passed, skipped, failed, and errors don't sum up to the total number of tests ran (322).

I couldn't attach the file, but here's the beginning of the rest of the HTML file:

EXPECTED_OK | /dom/abort/event.any.worker.html | 1.28 |  

EXPECTED_OK | /dom/abort/event.any.html | 0.37 |  

EXPECTED_OK | /dom/collections/HTMLCollection-as-prototype.html | 0.37 |  

EXPECTED_OK | /dom/collections/HTMLCollection-delete.html | 1.18 |  

EXPECTED_OK | /dom/collections/HTMLCollection-empty-name.html | 1.02 |  

EXPECTED_OK | /dom/collections/HTMLCollection-supported-property-indices.html | 0.37 |  

EXPECTED_OK | /dom/collections/HTMLCollection-supported-property-names.html | 1.08 |  

EXPECTED_OK | /dom/collections/domstringmap-supported-property-names.html | 0.87 |  

EXPECTED_OK | /dom/collections/namednodemap-supported-property-names.html | 0.42 |  

EXPECTED_OK | /dom/events/AddEventListenerOptions-once.html | 0.42 |  

EXPECTED_OK | /dom/events/AddEventListenerOptions-passive.html | 0.32 |  

EXPECTED_OK | /dom/events/CustomEvent.html | 0.32 |  

EXPECTED_OK | /dom/events/Event-cancelBubble.html | 0.37 |  

EXPECTED_OK | /dom/events/Event-constants.html | 0.47 |  

EXPECTED_OK | /dom/events/Event-constructors.html | 0.52 |  

EXPECTED_OK | /dom/events/Event-defaultPrevented-after-dispatch.html | 0.37 |  

EXPECTED_OK | /dom/events/Event-defaultPrevented.html | 0.42 |  

EXPECTED_OK | /dom/events/Event-dispatch-bubble-canceled.html | 0.37 |  

EXPECTED_OK | /dom/events/Event-dispatch-bubbles-false.html | 0.37 |  

EXPECTED_OK | /dom/events/Event-dispatch-bubbles-true.html | 0.42 |  

EXPECTED_OK | /dom/events/Event-dispatch-click.html | 0.42 |  

EXPECTED_OK | /dom/events/Event-dispatch-detached-click.html | 0.42 |  

EXPECTED_OK | /dom/events/Event-dispatch-handlers-changed.html | 0.47 |  

EXPECTED_OK | /dom/events/Event-dispatch-listener-order.window.html | 0.87 |  

EXPECTED_OK | /dom/events/Event-dispatch-multiple-cancelBubble.html | 1.02 |  

EXPECTED_OK | /dom/events/Event-dispatch-multiple-stopPropagation.html | 0.37 |  

EXPECTED_OK | /dom/events/Event-dispatch-omitted-capture.html | 0.47 |  

UNEXPECTED_TIMEOUT | /dom/events/Event-dispatch-on-disabled-elements.html | 60.38 |  

EXPECTED_OK | /dom/events/Event-dispatch-order.html | 0.87 |  

EXPECTED_OK | /dom/events/Event-dispatch-other-document.html | 0.42 |  

EXPECTED_OK | /dom/events/Event-dispatch-propagation-stopped.html | 0.37
...

@galmacky
Copy link
Contributor Author

@Hexcles

@Hexcles Hexcles changed the title ChromeAndroid: HTML report show incorrect summary HTML report (--log-html) show incorrect summary Aug 14, 2019
@Hexcles
Copy link
Member

Hexcles commented Aug 14, 2019

This is a general issue related to the HTML log handler (or its interaction with wptrunner). I've tried Firefox & Chrome and the numbers are also wrong in the HTML file.

AFAIK, no one really uses the html report and it must have bit-rotten somewhere...

What do you need it for? The JSON format (--log-wptreport) is much easier to consume.

@Hexcles Hexcles added infra priority:backlog wptrunner The automated test runner, commonly called through ./wpt run labels Aug 14, 2019
@Hexcles Hexcles changed the title HTML report (--log-html) show incorrect summary HTML report (--log-html) shows incorrect summary Aug 14, 2019
@galmacky
Copy link
Contributor Author

galmacky commented Aug 14, 2019 via email

@Hexcles
Copy link
Member

Hexcles commented Aug 14, 2019

Are your needs ranked by importance? I'm afraid we don't have a logger that can satisfy all the needs at the moment.

The default --log-grouped is a human-friendly, streaming log that tells you both the progress and the detail stack trace (2 & 3).

Also, it seems to provide only two levels of details.

Are you saying the JSON does not have stack trace?

@galmacky
Copy link
Contributor Author

galmacky commented Aug 16, 2019 via email

@Hexcles
Copy link
Member

Hexcles commented Aug 16, 2019

Hmm, the grouped logger doesn't seem to be able to log to a file. --log-grouped - works fine. @jgraham is this expected?

As for the JSON report, yes the results field of the top-level object is just a list of individual test results without the directory structure. Some post-processing is needed to get the counts you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra priority:backlog wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

No branches or pull requests

2 participants