CSS: Shortest serialization for gap shorthand #18407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 13, 2019
gap is <'row-gap'> <'column-gap'>? https://drafts.csswg.org/css-align-3/#propdef-gap If row-gap and column-gap are the same, we serialize only a single value, consistent with Firefox and the shortest representation principle. https://drafts.csswg.org/cssom/#serializing-css-values Change-Id: I8a2380d963cdbb7f33676b435d9cfb909abf9e77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750521 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#686773}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1750521
branch
from
3db3aff
to
55c6cc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gap is <'row-gap'> <'column-gap'>?
https://drafts.csswg.org/css-align-3/#propdef-gap
If row-gap and column-gap are the same, we serialize
only a single value, consistent with Firefox and
the shortest representation principle.
https://drafts.csswg.org/cssom/#serializing-css-values
Change-Id: I8a2380d963cdbb7f33676b435d9cfb909abf9e77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750521
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686773}