gnome3.evolution-data-server: Hardcode more GSettings schemas #66531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
the
6.topic: GNOME
jtojnar
force-pushed
the
eds-hardcode-gschemas
branch
2 times, most recently
from
22e2be4
to
8984754
Compare
Ooh that's very useful. Is there something like this for python? |
I used Coccinelle to create a base patch:
spatch --sp-file hardcode-gsettings.cocci --dir src/ --in-place
```cocci
@@
expression GSETTINGS_SCHEMA;
expression settings;
@@
- settings = g_settings_new (GSETTINGS_SCHEMA);
+ {
+ GSettingsSchemaSource *schema_source;
+ GSettingsSchema *schema;
+ schema_source = g_settings_schema_source_new_from_directory ("@ESD_GSETTINGS_PATH@", g_settings_schema_source_get_default (), TRUE, NULL);
+ schema = g_settings_schema_source_lookup (schema_source, GSETTINGS_SCHEMA, FALSE);
+ settings = g_settings_new_full (schema, NULL, NULL);
+ g_settings_schema_source_unref (schema_source);
+ g_settings_schema_unref (schema);
+ }
```
jtojnar
force-pushed
the
eds-hardcode-gschemas
branch
from
8984754
to
80cb879
Compare
|
Seems to fix the Geary crashes I encountered. |
Should I do any manual checks on the patches being applied on the source code? |
|
If you have any ideas what to check… |
Bet the tests offer enough coverage to see nothing's gone awry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Geary crashes for me with
I used Coccinelle to create a base patch:
spatch --sp-file hardcode-gsettings.cocci --dir src/ --in-placeand then manually fixed the conflict & gsettings-desktop-schemas path.