Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/zabbixProxy: fix database initialization logic #66591

Merged
merged 1 commit into from Aug 17, 2019
Merged

nixos/zabbixProxy: fix database initialization logic #66591

merged 1 commit into from Aug 17, 2019

Conversation

aanderse
Copy link
Member

Motivation for this change

bug in zabbix proxy database initialization

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @mmahut

@aanderse aanderse changed the title zabbixProxy: fix database initialization logic nixos/zabbixProxy: fix database initialization logic Aug 13, 2019
@aanderse aanderse requested a review from mmahut August 16, 2019 01:04
@aanderse
Copy link
Member Author

@GrahamcOfBorg build zabbix.proxy-mysql zabbix.proxy-pgsql zabbix.proxy-sqlite

@aanderse
Copy link
Member Author

I have a zabbix proxy running using zabbix.proxy-mysql on this branch now. It would be nice to have a quick zabbix.proxy-pgsql and zabbix.proxy-sqlite test run if possible, though not entirely required from my perspective as this is somewhat straightforward.

@aanderse aanderse marked this pull request as ready for review August 16, 2019 23:58
@mmahut
Copy link
Member

mmahut commented Aug 17, 2019

Tested both pgsql and sqlite. Looks good to me.

@mmahut mmahut merged commit caf9b8c into NixOS:master Aug 17, 2019
@aanderse aanderse deleted the zabbix-proxy branch August 17, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut Awaiting requested review from mmahut

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aanderse @mmahut