WPT tests for WebXR SameObject attributes #18410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 13, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1752934
branch
2 times, most recently
from
feecb7e
to
84be25f
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1752934
branch
from
84be25f
to
da0ae6f
Compare
Adding [SaveSameObject] and a reference to the attribute in
v8_private_property.h is required for the [SameObject] FrozenArray
attributes to have the expected behavior.
Attributes now covered by tests:
Navigator.xr
XRSession.{renderState,inputSources}
XRView.{projectionMatrix,transform}
XRRigidTransform.{position,orientation,inverse}
XRPose.transform
XRViewerPose.views
XRInputSource.{targetRaySpace,gripSpace,profiles}
XRWebGLLayer.framebuffer
XRSessionEvent.session
XRInputSourceEvent.{frame,inputSource}
XRInputSourcesChangeEvent.{session,added,removed}
XRReferenceSpaceEvent.{referenceSpace,transform}
Bug: 960958
Change-Id: I8582909c3e87ec0bfe05e443416708a54f606bd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752934
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687756}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1752934
branch
from
da0ae6f
to
8c4fa40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding [SaveSameObject] and a reference to the attribute in
v8_private_property.h is required for the [SameObject] FrozenArray
attributes to have the expected behavior.
Attributes now covered by tests:
Navigator.xr
XRSession.{renderState,inputSources}
XRView.{projectionMatrix,transform}
XRRigidTransform.{position,orientation,inverse}
XRPose.transform
XRViewerPose.views
XRInputSource.{targetRaySpace,gripSpace,profiles}
XRWebGLLayer.framebuffer
XRSessionEvent.session
XRInputSourceEvent.{frame,inputSource}
XRInputSourcesChangeEvent.{session,added,removed}
XRReferenceSpaceEvent.{referenceSpace,transform}
Bug: 960958
Change-Id: I8582909c3e87ec0bfe05e443416708a54f606bd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752934
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687756}