Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use qt5's mkDerivation for packages I maintain #66577

Merged
merged 8 commits into from Aug 19, 2019
Merged

use qt5's mkDerivation for packages I maintain #66577

merged 8 commits into from Aug 19, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 13, 2019

Motivation for this change

See #65399

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@bjornfor bjornfor merged commit f72d204 into NixOS:master Aug 19, 2019
@ghost
Copy link
Author

ghost commented Aug 19, 2019

@bjornfor Thank you!

@ghost ghost deleted the qt5 branch August 19, 2019 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant