kernelPatches: mac nvme t2 support #66576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disassembler
force-pushed
the
nvme-apple-ssd
branch
from
47fc288
to
87076f1
Compare
Mic92
reviewed
Aug 15, 2019
| + ctrl->ctrl_config &= ~(0xfu << NVME_CC_IOSQES_SHIFT); | ||
| + ctrl->ctrl_config |= ctrl->iosqes << NVME_CC_IOSQES_SHIFT; | ||
| + ret = ctrl->ops->reg_write32(ctrl, NVME_REG_CC, | ||
| + ctrl->ctrl_config); |
There was a problem hiding this comment.
That part might need some testing on different devices. But since this patch is not applied by default, it should be safe to have it in nixpkgs.
disassembler
force-pushed
the
nvme-apple-ssd
branch
from
87076f1
to
13d5fc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
OSX nvme disk was not showing at all after booting off an installer: https://lkml.org/lkml/2019/7/15/1748
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @