Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zplug: init at 2.4.2. #66508

Closed
wants to merge 2 commits into from
Closed

zplug: init at 2.4.2. #66508

wants to merge 2 commits into from

Conversation

kayhide
Copy link
Contributor

@kayhide kayhide commented Aug 12, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@kayhide
Copy link
Contributor Author

kayhide commented Aug 12, 2019

@mmahut Thanks for your review. I updated all items you pointed.
Please take a look.

@mmahut
Copy link
Member

mmahut commented Aug 12, 2019

@GrahamcOfBorg build zplug

@kayhide kayhide changed the title zplug: init at 2.3.4. zplug: init at 2.4.2. Aug 13, 2019
@mmahut
Copy link
Member

mmahut commented Aug 20, 2019

@GrahamcOfBorg build zplug

@kayhide
Copy link
Contributor Author

kayhide commented Sep 1, 2019 •
edited

As commented at #66629 (comment) , I updated maintainer list and added github id.

@mmahut
Copy link
Member

mmahut commented Sep 2, 2019

@GrahamcOfBorg build zplug

aanderse
aanderse requested changes Sep 2, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few comments I hope you find helpful.

pkgs/shells/zsh/zplug/default.nix Outdated
sha256 = "0hci1pbs3k5icwfyfw5pzcgigbh9vavprxxvakg1xm19n8zb61b3";
};

phases = "installPhase";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid use of phases if possible. #28910

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed phases and added the following instead.

  configurePhase = ''

  '';

  buildPhase = ''

  '';

Is this what we want?

pkgs/shells/zsh/zplug/default.nix Show resolved Hide resolved
pkgs/shells/zsh/zplug/default.nix Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@kayhide
Copy link
Contributor Author

kayhide commented Jun 4, 2020

Same PR was open at #83856 and introduced at 71a768a

Closing

@kayhide kayhide closed this Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

@aanderse aanderse aanderse requested changes

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kayhide @mmahut @aanderse @Janik-Haag