Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libpinyin: 2.1.91 -> 2.3.0 #66507

Merged
merged 1 commit into from Aug 12, 2019
Merged

libpinyin: 2.1.91 -> 2.3.0 #66507

merged 1 commit into from Aug 12, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 12, 2019 •
edited

Motivation for this change

fixing builds that @r-ryantm fails to update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

3 package were build:
fcitx-engines.libpinyin ibus-engines.libpinyin libpinyin

@mmahut
Copy link
Member

mmahut commented Aug 12, 2019

@GrahamcOfBorg build libpinyin

@mmahut mmahut merged commit 9acb728 into NixOS:master Aug 12, 2019
@jonringer jonringer deleted the bump-libpinyin branch August 12, 2019 14:57
@jonringer
Copy link
Contributor Author

thanks @mmahut for the speedy review! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @mmahut