[WebNFC] Distinguish between NFC not available and not enabled #18416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 14, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1751948
branch
from
87c8bef
to
afefd88
Compare
Following spec change at w3c/web-nfc#237, this CL allows web developers to distinguish when NFC is not available and when it's disabled by user preference. Bug: 520391 Change-Id: I3927d855edef1b1cf9b2036a0b4991745b962e04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751948 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#686762}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1751948
branch
from
afefd88
to
9857b40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following spec change at w3c/web-nfc#237, this
CL allows web developers to distinguish when NFC is not available and
when it's disabled by user preference.
Bug: 520391
Change-Id: I3927d855edef1b1cf9b2036a0b4991745b962e04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751948
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Cr-Commit-Position: refs/heads/master@{#686762}