Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cri-tools: 1.14.0 -> 1.15.0 #66608

Merged
merged 1 commit into from Aug 14, 2019
Merged

cri-tools: 1.14.0 -> 1.15.0 #66608

merged 1 commit into from Aug 14, 2019

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Aug 14, 2019

Motivation for this change
  • Bump cri-tools to the latest release
  • Fix go build process to include critest as well.
  • Fix GitHub repo location to be kubernetes-sigs
  • Add me as maintainer
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

- Fix go build process to include critest as well.
- Fix GitHub repo location to be `kubernetes-sigs`
- Add me as maintainer

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without any failures
  • run and tested the binaries

@mmahut
Copy link
Member

mmahut commented Aug 14, 2019

@GrahamcOfBorg build cri-tools

@mmahut mmahut merged commit 930659b into NixOS:master Aug 14, 2019
@saschagrunert saschagrunert deleted the cri-tools branch August 14, 2019 11:09
@jlesquembre jlesquembre mentioned this pull request Aug 15, 2019
10 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants