Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/riemann-tools: Add ExtraArgs Config Option #66606

Merged
merged 1 commit into from Aug 18, 2019
Merged

nixos/riemann-tools: Add ExtraArgs Config Option #66606

merged 1 commit into from Aug 18, 2019

Conversation

DerTim1
Copy link

@DerTim1 DerTim1 commented Aug 14, 2019

Added option "extraArgs" to forward any switches to riemann-tools.

Motivation for this change

Add NixOS config option (ExtraArgs) to be able to customize the monitoring client.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @mmahut

Added option "extraArgs" to forward any switches to riemann-tools.
@mmahut
Copy link
Member

mmahut commented Aug 18, 2019

Tested the service, works as expected.

@mmahut mmahut merged commit e6fb350 into NixOS:master Aug 18, 2019
@infinisil infinisil mentioned this pull request Aug 31, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants