Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions "neutral" exit code is incorrectly interpreted as failure #18392

Closed
jugglinmike opened this issue Aug 12, 2019 · 4 comments
Closed

Comments

@jugglinmike
Copy link
Contributor

As of today, GitHub Actions that we've designed to signal a "neutral" status are being reported as failing. The only change in this repository that coincides with the unexpected behavior is our migration to the latest "beta" release of the service. That makes me suspect a regression, so I've reported the problem in the GitHub Community Forum:

https://github.community/t5/GitHub-API-Development-and/GitHub-Actions-quot-neutral-quot-exit-code-is-incorrectly/m-p/29051

@jugglinmike
Copy link
Contributor Author

No response from GitHub yet, but the failing status continues to confuse contributors. As of gh-18417, we're temporarily reporting "success" for these cases since that's more accurate. We'll revert that change once the underlying issue with GitHub has been resolved.

@jugglinmike
Copy link
Contributor Author

A fellow GitHub user has observed that this feature may have been intentionally removed:

The neutral exit code isn't mentioned in the new documentation, so I don't think it's supported anymore.

We still haven't received word from a GitHub representative, though.

@jugglinmike
Copy link
Contributor Author

A GitHub employee has confirmed via Twitter:

We did, we'll have a different neutral exit strategy. exit 78 seems unique, but isn't. (eg, git merge exits with the number of conflicts encountered.)

It sounds like the neutral status will be supported in the future, so maybe we ought to keep this issue open until that's available.

@foolip
Copy link
Member

foolip commented May 6, 2021

We're no longer using the neutral code for GitHub Actions, and I doubt it's coming back to GitHub Actions. It makes more sense with the generic GitHub Checks API, where actions can be taken to resolve such inconclusive checks.

@foolip foolip closed this as completed May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants