Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LargestContentfulPaint] Re-enable untrusted scroll test #18411

Merged
merged 1 commit into from Aug 14, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Aug 13, 2019

The test was disabled because it landed too close to the change which changed
the startTime to not be 0. After addressing that change, the test now passes.

Bug: 987915
Change-Id: Id19623083aa141f7c3b541ad490db6395add6f8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753082
Auto-Submit: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686787}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

The test was disabled because it landed too close to the change which changed
the startTime to not be 0. After addressing that change, the test now passes.

Bug: 987915
Change-Id: Id19623083aa141f7c3b541ad490db6395add6f8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753082
Auto-Submit: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686787}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants