Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix crashDump overheating #66593

Merged
merged 1 commit into from Aug 13, 2019
Merged

fix crashDump overheating #66593

merged 1 commit into from Aug 13, 2019

Conversation

aaronjanse
Copy link
Member

Motivation for this change

fix #66464 so that boot.crashDump.enable = true no longer severely overheats CPU

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aaronjanse aaronjanse changed the title nixos/modules/misc/crashdump: remove idle=poll fix crashDump overheating Aug 13, 2019
@worldofpeace
Copy link
Contributor

Can you mention what this fixed in the commit msg and reference the issue?

@aaronjanse
nixos/modules/misc/crashdump: remove idle=poll (fix NixOS#66464)
011fa89 
Previously, "idle=poll" would severely overheat some CPUs
@aaronjanse
Copy link
Member Author

@worldofpeace fixed

@worldofpeace worldofpeace merged commit d66f890 into NixOS:master Aug 13, 2019
@aaronjanse aaronjanse deleted the crashdump-poll-fix branch August 13, 2019 23:11
@worldofpeace
Copy link
Contributor

I'm going to backport this to stable because it's dangerous in its current state.

@worldofpeace
Copy link
Contributor

Backported in 65729e0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

boot.crashDump.enable = true severely overheats CPU
2 participants
@aaronjanse @worldofpeace