qtstyleplugin-kvantum: use wrapQtAppsHook #66551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Shados do you mind splitting that new package into a separate commit? |
mmahut
reviewed
Aug 25, 2019
pkgs/development/libraries/qtstyleplugin-kvantum/default.nix.orig
Outdated
Show resolved
Hide resolved
mmahut
reviewed
Aug 25, 2019
pkgs/development/libraries/qtstyleplugin-kvantum/default.nix.orig
Outdated
Show resolved
Hide resolved
|
@GrahamcOfBorg build qtstyleplugin-kvantum |
Shouldn't be needed for the style engine itself to work, but it is needed for `kvantummanager` and `kvantumpreview`.
Shados
force-pushed
the
qt-wrap-kvantum
branch
from
53108c3
to
30360cb
Compare
|
@mmahut there's no new package, just some weirdness on my end generated a spurious clone of the file o.0. I've fixed that and the noted style issue, and added a commit for the version bump to 0.11.2, which runs OK on my system. |
|
@GrahamcOfBorg build qtstyleplugin-kvantum |
|
@GrahamcOfBorg build qtstyleplugin-kvantum-qt4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#65399
Shouldn't be needed for the style engine itself to work (I think), but it is needed for
kvantummanagerandkvantumpreview.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @bugworm