nvidia: prime render offload #66601

eadwu · 2019-08-14T02:45:35Z

Motivation for this change

Things done

Notify maintainers

cc @

eadwu · 2019-08-14T02:45:43Z

Patched xorg.xorgserver
Loaded modesetting and glamoregl
Added Option "AllowNVIDIAGPUScreens"
Got NVIDIA(G0) in journalctl
Got NVIDIA-G0 provider in xrandr
Loaded nvidia_drm

Device is detected, nvidia-smi output

➜ nvidia-smi
Tue Aug 13 22:44:48 2019
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 435.17       Driver Version: 435.17       CUDA Version: 10.1     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|===============================+======================+======================|
|   0  GeForce GTX 105...  Off  | 00000000:01:00.0 Off |                  N/A |
| N/A   59C    P8    N/A /  N/A |     36MiB /  4042MiB |      0%      Default |
+-------------------------------+----------------------+----------------------+

+-----------------------------------------------------------------------------+
| Processes:                                                       GPU Memory |
|  GPU       PID   Type   Process name                             Usage      |
|=============================================================================|
+-----------------------------------------------------------------------------+

Still broken

➜ __NV_PRIME_RENDER_OFFLOAD=1 __GLX_VENDOR_LIBRARY_NAME=nvidia glxinfo
name of display: :0
X Error of failed request:  BadMatch (invalid parameter attributes)
  Major opcode of failed request:  156 (NV-GLX)
  Minor opcode of failed request:  43 ()
  Serial number of failed request:  17
  Current serial number in output stream:  18

eadwu · 2019-08-14T17:46:12Z

Confirmed PRIME synchronization and render offload works fine on my device.

~
➜ glxinfo | rg vendor
server glx vendor string: SGI
client glx vendor string: Mesa Project and SGI
OpenGL vendor string: Intel

~
➜ nvidia-offload glxinfo | rg vendor
server glx vendor string: NVIDIA Corporation
client glx vendor string: NVIDIA Corporation
OpenGL vendor string: NVIDIA Corporation

~
➜ nvidia-smi
Wed Aug 14 13:45:53 2019
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 435.17       Driver Version: 435.17       CUDA Version: 10.1     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|===============================+======================+======================|
|   0  GeForce GTX 105...  Off  | 00000000:01:00.0 Off |                  N/A |
| N/A   61C    P3    N/A /  N/A |     37MiB /  4042MiB |      0%      Default |
+-------------------------------+----------------------+----------------------+

+-----------------------------------------------------------------------------+
| Processes:                                                       GPU Memory |
|  GPU       PID   Type   Process name                             Usage      |
|=============================================================================|
+-----------------------------------------------------------------------------+

pkgs/servers/x11/xorg/overrides.nix

ghost

Looks like hashes are changing

pkgs/servers/x11/xorg/overrides.nix

nixos/modules/hardware/video/nvidia.nix

ghost · 2019-09-01T08:14:15Z

@eadwu
Can't get it work correctly

Devices

00:02.0 VGA compatible controller: Intel Corporation HD Graphics 620 (rev 02)
01:00.0 3D controller: NVIDIA Corporation GP108M [GeForce MX150] (rev a1)

Configuration

  services.xserver.videoDrivers = [ "modesetting" "nvidia" ];
  hardware.nvidia.prime.offload.enable = true;
  hardware.nvidia.prime.nvidiaBusId = "PCI:1:0:0";
  hardware.nvidia.prime.intelBusId = "PCI:0:2:0";

Interesting why X server is listed here?

$ nvidia-smi
Sun Sep  1 11:02:54 2019       
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 435.21       Driver Version: 435.21       CUDA Version: 10.1     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|===============================+======================+======================|
|   0  GeForce MX150       Off  | 00000000:01:00.0 Off |                  N/A |
| N/A   40C    P8    N/A /  N/A |     28MiB /  2002MiB |      0%      Default |
+-------------------------------+----------------------+----------------------+
                                                                               
+-----------------------------------------------------------------------------+
| Processes:                                                       GPU Memory |
|  GPU       PID   Type   Process name                             Usage      |
|=============================================================================|
|    0      1136      G   ...gbim0idpi4fn42-xorg-server-1.20.5/bin/X    28MiB |
+-----------------------------------------------------------------------------+

$ xrandr --listproviders
Providers: number : 2
Provider 0: id: 0x1df cap: 0xf, Source Output, Sink Output, Source Offload, Sink Offload crtcs: 3 outputs: 4 associated providers: 0 name:modesetting
Provider 1: id: 0x1b8 cap: 0x0 crtcs: 0 outputs: 0 associated providers: 0 name:NVIDIA-G0

$ glxinfo | grep vendor
server glx vendor string: SGI
client glx vendor string: Mesa Project and SGI
OpenGL vendor string: Intel Open Source Technology Center

$ __NV_PRIME_RENDER_OFFLOAD=1 __GLX_VENDOR_LIBRARY_NAME=nvidia glxinfo | grep vendor
server glx vendor string: NVIDIA Corporation
client glx vendor string: NVIDIA Corporation
OpenGL vendor string: NVIDIA Corporation

Don't see any picture with these

$ __NV_PRIME_RENDER_OFFLOAD=1 __GLX_VENDOR_LIBRARY_NAME=nvidia glxgears
$ __NV_PRIME_RENDER_OFFLOAD_PROVIDER=NVIDIA-G0 __GLX_VENDOR_LIBRARY_NAME=nvidia glxgears

eadwu · 2019-09-01T19:27:03Z

Not sure why the X process is there. Reproduced the glxgears issue. Not sure why it doesn't show but I'll have a look whenever I have more time.

nixos-discourse · 2019-09-06T17:35:01Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/fix-bumblebee-kernel-panic/3933/2

ghost · 2019-09-06T19:12:44Z

Got Vulkan to work eadwu#17

eadwu · 2019-09-06T20:45:11Z

I'm probably only going to have time to look into this later during the weekend, depending on the time I finish university things.

eadwu · 2020-01-26T21:16:12Z

As of the current point, if there aren't any bugs anyone is experiencing, I would say this PR is good to go.

lovesegfault · 2020-01-31T01:28:02Z

Is @baracoder the only missing review?

nixos-discourse · 2020-02-05T17:10:48Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/114

patrl · 2020-02-10T21:31:07Z

Is there anything preventing this from being merged? I've been eagerly waiting for this to land in master.

cawilliamson · 2020-03-01T11:24:45Z

I'd love to see this merged! My battery life is suffering every day this isn't merged! :(

romildo

Tested on a Dell G3 3579 (Intel Corporation UHD Graphics 630 / GeForce GTX 1050 Ti Mobile). Looks good to me.

ghost · 2020-04-21T07:19:11Z

Backport to 20.03 anyone?

eadwu · 2020-04-21T18:25:46Z

I was under the thought that new features shouldn't be backported? Though if some people want to be on 20.03 instead of unstable I can open a PR.

ghost · 2020-04-22T13:07:31Z

@eadwu Imho this is 2019 year feature, would be cool to see it on 20.03

eadwu · 2020-04-26T05:36:49Z

I'll open one up later today and see how it goes.

eadwu · 2020-04-27T02:45:53Z

#86094

nvidia: prime render offload (cherry picked from commit 74f5358)

nh2 · 2020-06-15T00:13:44Z

@shyim I think your 2 edits to the Nvidia NixOS wiki article are in error:

https://nixos.wiki/index.php?title=Nvidia&diff=4211&oldid=4189
- This one changes offload.enable = true to sync.enable = true; in the "Offload" section, which achieves the exact opposite effect.
- Also changes prime back to optimus_prime.
https://nixos.wiki/index.php?title=Nvidia&diff=4189&oldid=4161
- This one changes prime back to optimus_prime.

I believe you may have missed the

Currently only in unstable, to be included in 20.09.

mentioned there, and changed it back because those settings don't exist in 20.03 (this sentence also currently unfortunately is present in only 1 of the 2 sections that refer to 20.09-only attributes).

I think we should undo the first change, and modify the second change so that it describes how to enable sync mode for both 20.09 (unstable) and 20.03.

nh2 · 2020-06-15T02:05:34Z

@eadwu Offloading seems to work well for me (I tested on 20.30 with your backport #86094 applied).

But even in offload mode, resume-from-suspend still does not work: #73494 (comment)

nh2 · 2020-06-15T12:26:19Z

I think we should undo the first change, and modify the second change so that it describes how to enable sync mode for both 20.09 (unstable) and 20.03.

I have done this now, and also cleaned up some syntax: https://nixos.wiki/index.php?title=Nvidia&diff=4266&oldid=4211

delan · 2020-10-20T06:34:39Z

Thanks for the hard work on this feature. I’m looking forward to reverse PRIME!

I’ve updated the wiki page to clarify that just like offload mode, only some laptops need modesetting to be added to videoDrivers. For example, doing so on my X1 Extreme (20QV) breaks external monitors and glxinfo, makes picom segfault, and makes firefox and chrome flicker every few seconds.

nh2 · 2021-06-21T00:03:57Z

nixos/modules/hardware/video/nvidia.nix

+      '';
+    };
+
+    hardware.nvidia.prime.sync.enable = mkOption {


@eadwu and others:

Soes prime.sync have anything to do with PRIME Synchronization? (Arch wiki link and NVIDIA link)

Or is it just the old name for "Optimus Prime's sync mode" as described in https://nixos.wiki/wiki/Nvidia#sync_mode ?

If the former, we should probably rename it, or at write this in the docs here and into the NixOS wiki.

Do you know?

Yes prime.sync refers to PRIME Synchronization. It was previously put as optimus_prime https://github.com/NixOS/nixpkgs/pull/66601/files#diff-28ea4da3a9a595f8bd1a37a555c229f998f3a11b0715ebc5842ba266384eba73L55 as why the section has two different versions.

nixos-discourse · 2022-10-17T00:23:52Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/laptop-graphics-card-not-detected-by-nixos-generate-config/22450/10

eadwu mentioned this pull request Aug 14, 2019

nvidia_x11_beta: stable -> 435.17 #66597

Closed

10 tasks

ofborg bot added 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 101-500 labels Aug 14, 2019

eadwu force-pushed the nvidia/prime-render-offload branch 4 times, most recently from db99540 to 3fc022e Compare August 14, 2019 16:43

eadwu marked this pull request as ready for review August 14, 2019 16:44

eadwu force-pushed the nvidia/prime-render-offload branch 3 times, most recently from d12e300 to 5a80896 Compare August 14, 2019 17:33

eadwu commented Aug 14, 2019

View reviewed changes

pkgs/servers/x11/xorg/overrides.nix Outdated Show resolved Hide resolved

eadwu force-pushed the nvidia/prime-render-offload branch 2 times, most recently from e03a73c to d81c3a1 Compare August 18, 2019 16:45

eadwu mentioned this pull request Aug 30, 2019

nvidia_x11: 430.40 -> 435.21 #67762

Merged

10 tasks

eadwu force-pushed the nvidia/prime-render-offload branch 2 times, most recently from 17c28dc to 721f3f8 Compare August 31, 2019 19:51

ghost suggested changes Sep 1, 2019

View reviewed changes

ghost reviewed Sep 1, 2019

View reviewed changes

nixos/modules/hardware/video/nvidia.nix Outdated Show resolved Hide resolved

ghost reviewed Sep 1, 2019

View reviewed changes

nixos/modules/hardware/video/nvidia.nix Outdated Show resolved Hide resolved

eadwu force-pushed the nvidia/prime-render-offload branch from 721f3f8 to aa55960 Compare September 1, 2019 19:24

baracoder approved these changes Jan 31, 2020

View reviewed changes

disassembler modified the milestones: 20.03, 20.09 Feb 5, 2020

eadwu mentioned this pull request Mar 1, 2020

nixos/nvidia: include systemd power management #73530

Merged

10 tasks

romildo self-requested a review March 1, 2020 17:24

romildo approved these changes Mar 1, 2020

View reviewed changes

romildo merged commit 74f5358 into NixOS:master Mar 1, 2020

mdedetrich mentioned this pull request May 10, 2020

nixos/nvidia : added nvidia-persistenced #77054

Merged

10 tasks

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jun 2, 2020

Merge pull request NixOS#66601 from eadwu/nvidia/prime-render-offload

61c4341

nvidia: prime render offload (cherry picked from commit 74f5358)

ghost mentioned this pull request Jul 2, 2020

nvidia optimus: display-manager restarts on system upgrades #86123

Closed

bahaynes mentioned this pull request Jul 26, 2020

Add system dell/xps/15-9500 NixOS/nixos-hardware#178

Merged

copyread mentioned this pull request Oct 11, 2020

20.09 Release notes #95765

Closed

10 tasks

eadwu deleted the nvidia/prime-render-offload branch November 17, 2020 23:33

nh2 reviewed Jun 21, 2021

View reviewed changes

Gerg-L mentioned this pull request Jul 17, 2023

nixos/nvidia: clean up and add dynamic boost #244060

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nvidia: prime render offload #66601

nvidia: prime render offload #66601

eadwu commented Aug 14, 2019 •

edited

eadwu commented Aug 14, 2019 •

edited

eadwu commented Aug 14, 2019

ghost left a comment

ghost commented Sep 1, 2019 •

edited by ghost

eadwu commented Sep 1, 2019

nixos-discourse commented Sep 6, 2019

ghost commented Sep 6, 2019

eadwu commented Sep 6, 2019

eadwu commented Jan 26, 2020

lovesegfault commented Jan 31, 2020

nixos-discourse commented Feb 5, 2020

patrl commented Feb 10, 2020

cawilliamson commented Mar 1, 2020

romildo left a comment

ghost commented Apr 21, 2020

eadwu commented Apr 21, 2020

ghost commented Apr 22, 2020

eadwu commented Apr 26, 2020

eadwu commented Apr 27, 2020

nh2 commented Jun 15, 2020

nh2 commented Jun 15, 2020

nh2 commented Jun 15, 2020

delan commented Oct 20, 2020

nh2 Jun 21, 2021 •

edited

eadwu Jun 21, 2021

nixos-discourse commented Oct 17, 2022

nvidia: prime render offload #66601

nvidia: prime render offload #66601

Conversation

eadwu commented Aug 14, 2019 • edited

Motivation for this change

Things done

Notify maintainers

eadwu commented Aug 14, 2019 • edited

eadwu commented Aug 14, 2019

ghost left a comment

Choose a reason for hiding this comment

ghost commented Sep 1, 2019 • edited by ghost

eadwu commented Sep 1, 2019

nixos-discourse commented Sep 6, 2019

ghost commented Sep 6, 2019

eadwu commented Sep 6, 2019

eadwu commented Jan 26, 2020

lovesegfault commented Jan 31, 2020

nixos-discourse commented Feb 5, 2020

patrl commented Feb 10, 2020

cawilliamson commented Mar 1, 2020

romildo left a comment

Choose a reason for hiding this comment

ghost commented Apr 21, 2020

eadwu commented Apr 21, 2020

ghost commented Apr 22, 2020

eadwu commented Apr 26, 2020

eadwu commented Apr 27, 2020

nh2 commented Jun 15, 2020

nh2 commented Jun 15, 2020

nh2 commented Jun 15, 2020

delan commented Oct 20, 2020

nh2 Jun 21, 2021 • edited

Choose a reason for hiding this comment

eadwu Jun 21, 2021

Choose a reason for hiding this comment

nixos-discourse commented Oct 17, 2022

eadwu commented Aug 14, 2019 •

edited

eadwu commented Aug 14, 2019 •

edited

ghost commented Sep 1, 2019 •

edited by ghost

nh2 Jun 21, 2021 •

edited