Rewrite interpolation-testcommon.js #18402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 13, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1752103
branch
6 times, most recently
from
e6c01fc
to
5c48a0b
Compare
Right now the wpt/css/support/interpolation-testcommon.js is very specific to interpolations using CSS animations. As a result, it is used by a few tests only. This CL rewrites the file. To be more specific, most of the code comes from web_tests/animations/interpolation/resources/interpolation-test.js, which runs the tests with several interpolation methods: 1. cssAnimationsInterpolation 2. cssTransitionsInterpolation 3. cssTransitionAllInterpolation 4. webAnimationsInterpolation With this general test file, a lot of existing interpolation test can use this. Furthermore, the intention is to move non-wpt interpolation and composition tests to wpt using this file. Bug: 900581 Change-Id: I1058c556932d28709bacdb08a4591c958aead937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752103 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#687264}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1752103
branch
from
5c48a0b
to
4c45b9c
Compare
|
Fix is coming: https://chromium-review.googlesource.com/c/chromium/src/+/1758486 force-merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the wpt/css/support/interpolation-testcommon.js is very
specific to interpolations using CSS animations. As a result, it is
used by a few tests only.
This CL rewrites the file. To be more specific, most of the code comes
from web_tests/animations/interpolation/resources/interpolation-test.js,
which runs the tests with several interpolation methods:
With this general test file, a lot of existing interpolation test can
use this. Furthermore, the intention is to move non-wpt interpolation
and composition tests to wpt using this file.
Bug: 900581
Change-Id: I1058c556932d28709bacdb08a4591c958aead937
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752103
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687264}